Commit 19205da6 authored by Petr Mladek's avatar Petr Mladek Committed by Jiri Kosina
Browse files

livepatch: Small shadow variable documentation fixes



The description of the basic operations was a bit inconsistent
and based on older version of the patchset.

Also the size of the spinlock structure should be allocated
instead of the pointer.
Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
Acked-by: default avatarJoe Lawrence <joe.lawrence@redhat.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 5d9da759
...@@ -6,7 +6,7 @@ Shadow variables are a simple way for livepatch modules to associate ...@@ -6,7 +6,7 @@ Shadow variables are a simple way for livepatch modules to associate
additional "shadow" data with existing data structures. Shadow data is additional "shadow" data with existing data structures. Shadow data is
allocated separately from parent data structures, which are left allocated separately from parent data structures, which are left
unmodified. The shadow variable API described in this document is used unmodified. The shadow variable API described in this document is used
to allocate/attach and detach/release shadow variables to their parents. to allocate/add and remove/free shadow variables to/from their parents.
The implementation introduces a global, in-kernel hashtable that The implementation introduces a global, in-kernel hashtable that
associates pointers to parent objects and a numeric identifier of the associates pointers to parent objects and a numeric identifier of the
...@@ -107,7 +107,7 @@ struct sta_info *sta_info_alloc(struct ieee80211_sub_if_data *sdata, ...@@ -107,7 +107,7 @@ struct sta_info *sta_info_alloc(struct ieee80211_sub_if_data *sdata,
sta = kzalloc(sizeof(*sta) + hw->sta_data_size, gfp); sta = kzalloc(sizeof(*sta) + hw->sta_data_size, gfp);
/* Attach a corresponding shadow variable, then initialize it */ /* Attach a corresponding shadow variable, then initialize it */
ps_lock = klp_shadow_alloc(sta, PS_LOCK, NULL, sizeof(ps_lock), gfp); ps_lock = klp_shadow_alloc(sta, PS_LOCK, NULL, sizeof(*ps_lock), gfp);
if (!ps_lock) if (!ps_lock)
goto shadow_fail; goto shadow_fail;
spin_lock_init(ps_lock); spin_lock_init(ps_lock);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment