Commit 2bdd4c28 authored by Uma Shankar's avatar Uma Shankar Committed by Rodrigo Vivi

drm/i915/display: Fix mode private_flags comparison at atomic_check

This patch fixes the private_flags of mode to be checked and
compared against uapi.mode and not from hw.mode. This helps
properly trigger modeset at boot if desired by driver.

It helps resolve audio_codec initialization issues if display
is connected at boot. Initial discussion on this issue has happened
on below thread:

v2: No functional change. Fixed the Closes tag and added
Maarten's RB.

v3: Added Fixes tag.

Cc: Ville Syrjä <>
Cc: Maarten Lankhorst <>
Cc: Kai Vehmanen <>
Cc: Souza, Jose <>
Fixes: 58d124ea ("drm/i915: Complete crtc hw/uapi split, v6.")
Closes: default avatarVille Syrjä <>
Signed-off-by: default avatarUma Shankar <>
Signed-off-by: default avatarSweeAun Khor <>
Reviewed-by: default avatarMaarten Lankhorst <>
(cherry picked from commit d5e56705)
Signed-off-by: default avatarRodrigo Vivi <>
parent a97b786b
......@@ -14748,8 +14748,8 @@ static int intel_atomic_check(struct drm_device *dev,
for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
new_crtc_state, i) {
if (new_crtc_state->hw.mode.private_flags !=
if (new_crtc_state->uapi.mode.private_flags !=
new_crtc_state->uapi.mode_changed = true;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment