Commit 33acc40d authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Rob Herring

of: unittest: Remove bogus overlay mutex release from overlay_data_add()

overlay_data_add() never takes the special overlay mutex, so it must not
be released in the error patch.

Presumably the call to of_overlay_mutex_unlock() is a relic from v1 of
the patch.

Fixes: f948d6d8 ("of: overlay: avoid race condition between applying multiple overlays")
Signed-off-by: default avatarGeert Uytterhoeven <>
Reviewed-by: default avatarFrank Rowand <>
Signed-off-by: default avatarRob Herring <>
parent 4fbd8d19
......@@ -2165,7 +2165,6 @@ static int __init overlay_data_add(int onum)
ret = of_overlay_apply(info->np_overlay, &info->overlay_id);
if (ret < 0) {
pr_err("of_overlay_apply() (ret=%d), %d\n", ret, onum);
goto out_free_np_overlay;
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment