Commit 540557b9 authored by Andy Whitcroft's avatar Andy Whitcroft Committed by Linus Torvalds
Browse files

sparsemem: record when a section has a valid mem_map

We have flags to indicate whether a section actually has a valid mem_map
associated with it.  This is never set and we rely solely on the present bit
to indicate a section is valid.  By definition a section is not valid if it
has no mem_map and there is a window during init where the present bit is set
but there is no mem_map, during which pfn_valid() will return true

Use the existing SECTION_HAS_MEM_MAP flag to indicate the presence of a valid
mem_map.  Switch valid_section{,_nr} and pfn_valid() to this bit.  Add a new
present_section{,_nr} and pfn_present() interfaces for those users who care to
know that a section is going to be valid.

[ coding-syle fixes]
Signed-off-by: default avatarAndy Whitcroft <>
Acked-by: default avatarMel Gorman <>
Cc: Christoph Lameter <>
Cc: "Luck, Tony" <>
Cc: Andi Kleen <>
Cc: "David S. Miller" <>
Cc: Paul Mackerras <>
Cc: Benjamin Herrenschmidt <>
Cc: KAMEZAWA Hiroyuki <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent cd881a6b
......@@ -238,7 +238,7 @@ store_mem_state(struct sys_device *dev, const char *buf, size_t count)
mem = container_of(dev, struct memory_block, sysdev);
phys_section_nr = mem->phys_index;
if (!valid_section_nr(phys_section_nr))
if (!present_section_nr(phys_section_nr))
goto out;
if (!strncmp(buf, "online", min((int)count, 6)))
......@@ -418,7 +418,7 @@ int register_new_memory(struct mem_section *section)
int unregister_memory_section(struct mem_section *section)
if (!valid_section(section))
if (!present_section(section))
return -EINVAL;
return remove_memory_block(0, section, 0);
......@@ -443,7 +443,7 @@ int __init memory_dev_init(void)
* during boot and have been initialized
for (i = 0; i < NR_MEM_SECTIONS; i++) {
if (!valid_section_nr(i))
if (!present_section_nr(i))
err = add_memory_block(0, __nr_to_section(i), MEM_ONLINE, 0);
if (!ret)
......@@ -771,12 +771,17 @@ static inline struct page *__section_mem_map_addr(struct mem_section *section)
return (struct page *)map;
static inline int valid_section(struct mem_section *section)
static inline int present_section(struct mem_section *section)
return (section && (section->section_mem_map & SECTION_MARKED_PRESENT));
static inline int section_has_mem_map(struct mem_section *section)
static inline int present_section_nr(unsigned long nr)
return present_section(__nr_to_section(nr));
static inline int valid_section(struct mem_section *section)
return (section && (section->section_mem_map & SECTION_HAS_MEM_MAP));
......@@ -798,6 +803,13 @@ static inline int pfn_valid(unsigned long pfn)
return valid_section(__nr_to_section(pfn_to_section_nr(pfn)));
static inline int pfn_present(unsigned long pfn)
if (pfn_to_section_nr(pfn) >= NR_MEM_SECTIONS)
return 0;
return present_section(__nr_to_section(pfn_to_section_nr(pfn)));
* These are _only_ used during initialisation, therefore they
* can use __initdata ... They could have names to indicate
......@@ -176,7 +176,7 @@ unsigned long __init node_memmap_size_bytes(int nid, unsigned long start_pfn,
if (nid != early_pfn_to_nid(pfn))
if (pfn_valid(pfn))
if (pfn_present(pfn))
nr_pages += PAGES_PER_SECTION;
......@@ -206,11 +206,12 @@ struct page *sparse_decode_mem_map(unsigned long coded_mem_map, unsigned long pn
static int __meminit sparse_init_one_section(struct mem_section *ms,
unsigned long pnum, struct page *mem_map)
if (!valid_section(ms))
if (!present_section(ms))
return -EINVAL;
ms->section_mem_map &= ~SECTION_MAP_MASK;
ms->section_mem_map |= sparse_encode_mem_map(mem_map, pnum);
ms->section_mem_map |= sparse_encode_mem_map(mem_map, pnum) |
return 1;
......@@ -256,7 +257,7 @@ void __init sparse_init(void)
struct page *map;
for (pnum = 0; pnum < NR_MEM_SECTIONS; pnum++) {
if (!valid_section_nr(pnum))
if (!present_section_nr(pnum))
map = sparse_early_mem_map_alloc(pnum);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment