Commit 657831ff authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

dccp/tcp: do not inherit mc_list from parent

syzkaller found a way to trigger double frees from ip_mc_drop_socket()

It turns out that leave a copy of parent mc_list at accept() time,
which is very bad.

Very similar to commit 8b485ce6

 ("tcp: do not inherit
fastopen_req from parent")

Initial report from Pray3r, completed by Andrey one.
Thanks a lot to them !
Signed-off-by: default avatarEric Dumazet <>
Reported-by: default avatarPray3r <>
Reported-by: default avatarAndrey Konovalov <>
Tested-by: default avatarAndrey Konovalov <>
Signed-off-by: default avatarDavid S. Miller <>
parent e735da5e
......@@ -794,6 +794,8 @@ struct sock *inet_csk_clone_lock(const struct sock *sk,
/* listeners have SOCK_RCU_FREE, not the children */
sock_reset_flag(newsk, SOCK_RCU_FREE);
inet_sk(newsk)->mc_list = NULL;
newsk->sk_mark = inet_rsk(req)->ir_mark;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment