Commit 68a39a3e authored by Wei Yongjun's avatar Wei Yongjun Committed by Bjorn Andersson

remoteproc: imx_rproc: fix return value check in imx_rproc_addr_init()

In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.
Reviewed-by: default avatarOleksij Rempel <>
Signed-off-by: default avatarWei Yongjun <>
Signed-off-by: default avatarBjorn Andersson <>
parent ab759b97
......@@ -269,10 +269,9 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
att->sa, att->size);
if (IS_ERR(priv->mem[b].cpu_addr)) {
if (!priv->mem[b].cpu_addr) {
dev_err(dev, "devm_ioremap_resource failed\n");
err = PTR_ERR(priv->mem[b].cpu_addr);
return err;
return -ENOMEM;
priv->mem[b].sys_addr = att->sa;
priv->mem[b].size = att->size;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment