Commit 899f0429 authored by Andreas Gruenbacher's avatar Andreas Gruenbacher Committed by Al Viro

direct-io: Prevent NULL pointer access in submit_page_section

In the code added to function submit_page_section by commit b1058b98,
sdio->bio can currently be NULL when calling dio_bio_submit.  This then
leads to a NULL pointer access in dio_bio_submit, so check for a NULL
bio in submit_page_section before trying to submit it instead.

Fixes xfstest generic/250 on gfs2.

Cc: # v3.10+
Signed-off-by: default avatarAndreas Gruenbacher <>
Reviewed-by: default avatarJan Kara <>
Signed-off-by: default avatarAl Viro <>
parent 8a5776a5
......@@ -866,7 +866,8 @@ submit_page_section(struct dio *dio, struct dio_submit *sdio, struct page *page,
if (sdio->boundary) {
ret = dio_send_cur_page(dio, sdio, map_bh);
dio_bio_submit(dio, sdio);
if (sdio->bio)
dio_bio_submit(dio, sdio);
sdio->cur_page = NULL;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment