Commit 8b0662f2 authored by Michal Hocko's avatar Michal Hocko Committed by Linus Torvalds
Browse files

mm, memory_hotplug: consider offline memblocks removable

is_pageblock_removable_nolock() relies on having zone association to
examine all the page blocks to check whether they are movable or free.
This is just wasting of cycles when the memblock is offline.  Later
patch in the series will also change the time when the page is
associated with a zone so we let's bail out early if the memblock is


Signed-off-by: default avatarMichal Hocko <>
Reported-by: default avatarIgor Mammedov <>
Acked-by: default avatarVlastimil Babka <>
Cc: Andi Kleen <>
Cc: Andrea Arcangeli <>
Cc: Balbir Singh <>
Cc: Dan Williams <>
Cc: Daniel Kiper <>
Cc: David Rientjes <>
Cc: Heiko Carstens <>
Cc: Jerome Glisse <>
Cc: Joonsoo Kim <>
Cc: Martin Schwidefsky <>
Cc: Mel Gorman <>
Cc: Reza Arbab <>
Cc: Tobias Regnery <>
Cc: Toshi Kani <>
Cc: Vitaly Kuznetsov <>
Cc: Xishi Qiu <>
Cc: Yasuaki Ishimatsu <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 9037a993
......@@ -128,6 +128,9 @@ static ssize_t show_mem_removable(struct device *dev,
int ret = 1;
struct memory_block *mem = to_memory_block(dev);
if (mem->state != MEM_ONLINE)
goto out;
for (i = 0; i < sections_per_block; i++) {
if (!present_section_nr(mem->start_section_nr + i))
......@@ -135,6 +138,7 @@ static ssize_t show_mem_removable(struct device *dev,
ret &= is_mem_section_removable(pfn, PAGES_PER_SECTION);
return sprintf(buf, "%d\n", ret);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment