Commit 9266a140 authored by Konstantin Khlebnikov's avatar Konstantin Khlebnikov Committed by Linus Torvalds
Browse files

mm/filemap.c: warn if stale pagecache is left after direct write

generic_file_direct_write() tries to invalidate pagecache after O_DIRECT
write.  Unlike to similar code in dio_complete() this silently ignores
error returned from invalidate_inode_pages2_range().

According to comment this code here because not all filesystems call
dio_complete() to do proper invalidation after O_DIRECT write.  Noticeable
example is a blkdev_direct_IO().

This patch calls dio_warn_stale_pagecache() if invalidation fails.


Signed-off-by: default avatarKonstantin Khlebnikov <>
Reviewed-by: default avatarAndrew Morton <>
Reviewed-by: default avatarJan Kara <>
Cc: Jens Axboe <>
Cc: Alexander Viro <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent a92853b6
......@@ -3241,11 +3241,13 @@ generic_file_direct_write(struct kiocb *iocb, struct iov_iter *from)
* do not end up with dio_complete() being called, so let's not break
* them by removing it completely.
* Noticeable example is a blkdev_direct_IO().
* Skip invalidation for async writes or if mapping has no pages.
if (written > 0 && mapping->nrpages)
pos >> PAGE_SHIFT, end);
if (written > 0 && mapping->nrpages &&
invalidate_inode_pages2_range(mapping, pos >> PAGE_SHIFT, end))
if (written > 0) {
pos += written;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment