Commit 97ad2be1 authored by Sasha Levin's avatar Sasha Levin Committed by Linus Torvalds
Browse files

mm, hugetlb: correct bit shift in hstate_sizelog()



hstate_sizelog() would shift left an int rather than long, triggering
undefined behaviour and passing an incorrect value when the requested
page size was more than 4GB, thus breaking >4GB pages.
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Andrey Ryabinin <a.ryabinin@samsung.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 247b1447
...@@ -311,7 +311,8 @@ static inline struct hstate *hstate_sizelog(int page_size_log) ...@@ -311,7 +311,8 @@ static inline struct hstate *hstate_sizelog(int page_size_log)
{ {
if (!page_size_log) if (!page_size_log)
return &default_hstate; return &default_hstate;
return size_to_hstate(1 << page_size_log);
return size_to_hstate(1UL << page_size_log);
} }
static inline struct hstate *hstate_vma(struct vm_area_struct *vma) static inline struct hstate *hstate_vma(struct vm_area_struct *vma)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment