Commit 9efcc4a1 authored by David Howells's avatar David Howells Committed by Linus Torvalds
Browse files

afs: Fix unpinned address list during probing

When it's probing all of a fileserver's interfaces to find which one is
best to use, afs_do_probe_fileserver() takes a lock on the server record
and notes the pointer to the address list.

It doesn't, however, pin the address list, so as soon as it drops the
lock, there's nothing to stop the address list from being freed under

Fix this by taking a ref on the address list inside the locked section
and dropping it at the end of the function.

Fixes: 3bf0fb6f

 ("afs: Probe multiple fileservers simultaneously")
Signed-off-by: default avatarDavid Howells <>
Reviewed-by: default avatarMarc Dionne <>
Signed-off-by: default avatarLinus Torvalds <>
parent 60268940
......@@ -145,6 +145,7 @@ static int afs_do_probe_fileserver(struct afs_net *net,
ac.alist = rcu_dereference_protected(server->addresses,
atomic_set(&server->probe_outstanding, ac.alist->nr_addrs);
......@@ -163,6 +164,7 @@ static int afs_do_probe_fileserver(struct afs_net *net,
if (!in_progress)
return in_progress;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment