Commit c07d3533 authored by Daniel Thompson's avatar Daniel Thompson Committed by Jason Wessel

kdb: Fix handling of kallsyms_symbol_next() return value

kallsyms_symbol_next() returns a boolean (true on success). Currently
kdb_read() tests the return value with an inequality that
unconditionally evaluates to true.

This is fixed in the obvious way and, since the conditional branch is
supposed to be unreachable, we also add a WARN_ON().
Reported-by: default avatarDan Carpenter <>
Signed-off-by: default avatarDaniel Thompson <>
Cc: linux-stable <>
Signed-off-by: default avatarJason Wessel <>
parent bebc6082
......@@ -350,7 +350,7 @@ static char *kdb_read(char *buffer, size_t bufsize)
for (i = 0; i < count; i++) {
if (kallsyms_symbol_next(p_tmp, i) < 0)
if (WARN_ON(!kallsyms_symbol_next(p_tmp, i)))
kdb_printf("%s ", p_tmp);
*(p_tmp + len) = '\0';
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment