Commit caac1d5f authored by Heba Aamer's avatar Heba Aamer Committed by Linus Torvalds
Browse files

checkpatch: improve seq_print->seq_puts suggestion



Improve the format specifier test by removing any %% before looking for
any remaining % format specifier.
Signed-off-by: default avatarHeba Aamer <heba93aamer@gmail.com>
Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent f8e58219
......@@ -4854,7 +4854,8 @@ sub process {
# check for seq_printf uses that could be seq_puts
if ($sline =~ /\bseq_printf\s*\(.*"\s*\)\s*;\s*$/) {
my $fmt = get_quoted_string($line, $rawline);
if ($fmt ne "" && $fmt !~ /[^\\]\%/) {
$fmt =~ s/%%//g;
if ($fmt !~ /%/) {
if (WARN("PREFER_SEQ_PUTS",
"Prefer seq_puts to seq_printf\n" . $herecurr) &&
$fix) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment