Commit d8a84d33 authored by Will Deacon's avatar Will Deacon Committed by Linus Torvalds

samples/hw_breakpoint: drop use of kallsyms_lookup_name()

The 'data_breakpoint' test code is the only modular user of
kallsyms_lookup_name(), which was exported as part of fixing the test in
f60d24d2 ("hw-breakpoints: Fix broken hw-breakpoint sample module").

In preparation for un-exporting this symbol, switch the test over to using
__symbol_get(), which can be used to place breakpoints on exported
Signed-off-by: default avatarWill Deacon <>
Signed-off-by: default avatarAndrew Morton <>
Reviewed-by: default avatarChristoph Hellwig <>
Reviewed-by: default avatarMasami Hiramatsu <>
Reviewed-by: default avatarQuentin Perret <>
Cc: K.Prasad <>
Cc: Thomas Gleixner <>
Cc: Greg Kroah-Hartman <>
Cc: Frederic Weisbecker <>
Cc: Alexei Starovoitov <>
Cc: Miroslav Benes <>
Cc: Petr Mladek <>
Cc: Joe Lawrence <>
Link: default avatarLinus Torvalds <>
parent 4800314e
......@@ -23,7 +23,7 @@
struct perf_event * __percpu *sample_hbp;
static char ksym_name[KSYM_NAME_LEN] = "pid_max";
static char ksym_name[KSYM_NAME_LEN] = "jiffies";
module_param_string(ksym, ksym_name, KSYM_NAME_LEN, S_IRUGO);
MODULE_PARM_DESC(ksym, "Kernel symbol to monitor; this module will report any"
" write operations on the kernel symbol");
......@@ -41,9 +41,13 @@ static int __init hw_break_module_init(void)
int ret;
struct perf_event_attr attr;
void *addr = __symbol_get(ksym_name);
if (!addr)
return -ENXIO;
attr.bp_addr = kallsyms_lookup_name(ksym_name);
attr.bp_addr = (unsigned long)addr;
attr.bp_len = HW_BREAKPOINT_LEN_4;
attr.bp_type = HW_BREAKPOINT_W;
......@@ -66,6 +70,7 @@ static int __init hw_break_module_init(void)
static void __exit hw_break_module_exit(void)
printk(KERN_INFO "HW Breakpoint for %s write uninstalled\n", ksym_name);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment