Commit dcaf1123 authored by Paolo Bonzini's avatar Paolo Bonzini Committed by Linus Torvalds
Browse files

checkpatch: fix UNNECESSARY_KERN_LEVEL false positive



KERN_<LEVEL> is never redundant with printk_ratelimited or printk_once.
(Except perhaps in the sense that you could use e.g.  pr_err_ratelimited
or pr_err_once, but that would apply to printk as well).
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Cc: Andy Whitcroft <apw@canonical.com>
Acked-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent e23ef1f3
...@@ -4547,7 +4547,7 @@ sub process { ...@@ -4547,7 +4547,7 @@ sub process {
} }
# check for logging functions with KERN_<LEVEL> # check for logging functions with KERN_<LEVEL>
if ($line !~ /printk\s*\(/ && if ($line !~ /printk(?:_ratelimited|_once)?\s*\(/ &&
$line =~ /\b$logFunctions\s*\(.*\b(KERN_[A-Z]+)\b/) { $line =~ /\b$logFunctions\s*\(.*\b(KERN_[A-Z]+)\b/) {
my $level = $1; my $level = $1;
if (WARN("UNNECESSARY_KERN_LEVEL", if (WARN("UNNECESSARY_KERN_LEVEL",
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment