1. 24 Feb, 2017 1 commit
  2. 24 Jun, 2016 1 commit
    • Ben Hutchings's avatar
      nfsd: check permissions when setting ACLs · 99965378
      Ben Hutchings authored
      Use set_posix_acl, which includes proper permission checks, instead of
      calling ->set_acl directly.  Without this anyone may be able to grant
      themselves permissions to a file by setting the ACL.
      
      Lock the inode to make the new checks atomic with respect to set_acl.
      (Also, nfsd was the only caller of set_acl not locking the inode, so I
      suspect this may fix other races.)
      
      This also simplifies the code, and ensures our ACLs are checked by
      posix_acl_valid.
      
      The permission checks and the inode locking were lost with commit
      4ac7249e
      
      , which changed nfsd to use the set_acl inode operation directly
      instead of going through xattr handlers.
      Reported-by: default avatarDavid Sinquin <david@sinquin.eu>
      [agreunba@redhat.com: use set_posix_acl]
      Fixes: 4ac7249e
      
      
      Cc: Christoph Hellwig <hch@infradead.org>
      Cc: Al Viro <viro@zeniv.linux.org.uk>
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
      99965378
  3. 20 Jul, 2015 1 commit
  4. 15 Apr, 2015 1 commit
  5. 11 Jul, 2014 1 commit
  6. 22 May, 2014 1 commit
  7. 26 Jan, 2014 1 commit
  8. 18 Dec, 2012 1 commit
  9. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        bloc...
      5a0e3ad6
  10. 15 Dec, 2009 1 commit
  11. 14 Dec, 2009 2 commits
  12. 13 Nov, 2009 1 commit
  13. 04 Nov, 2009 1 commit
    • Peter Staubach's avatar
      nfsd: register NFS_ACL with rpcbind · 1b7e0403
      Peter Staubach authored
      
      
      Modify the NFS server to register the NFS_ACL services with the rpcbind
      daemon.  This allows the client to ping for the existence of the NFS_ACL
      support via commands such as "rpcinfo -t <server> nfs_acl".
      
      This patch also modifies the NFS_ACL support so that responses to
      version 2 NULLPROC requests can be made.
      
      The changelog for the patch which turned off this functionality
      mentioned something about not registering the NFS_ACL as being part of
      some tradition.  I can't find this tradition and the only other
      implementation which supports NFS_ACL does register them with the
      rpcbind daemon.
      Signed-off-by: default avatarPeter Staubach <staubach@redhat.com>
      Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      1b7e0403
  14. 23 Jun, 2008 1 commit
  15. 12 Nov, 2007 1 commit
  16. 08 Dec, 2006 1 commit
  17. 20 Oct, 2006 3 commits
  18. 04 Oct, 2006 2 commits
    • Olaf Kirch's avatar
      [PATCH] knfsd: register all RPC programs with portmapper by default · bc5fea42
      Olaf Kirch authored
      
      
      The NFSACL patches introduced support for multiple RPC services listening on
      the same transport.  However, only the first of these services was registered
      with portmapper.  This was perfectly fine for nfsacl, as you traditionally do
      not want these to show up in a portmapper listing.
      
      The patch below changes the default behavior to always register all services
      listening on a given transport, but retains the old behavior for nfsacl
      services.
      Signed-off-by: default avatarOlaf Kirch <okir@suse.de>
      Signed-off-by: default avatarNeil Brown <neilb@suse.de>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      bc5fea42
    • NeilBrown's avatar
      [PATCH] knfsd: Replace two page lists in struct svc_rqst with one · 44524359
      NeilBrown authored
      
      
      We are planning to increase RPCSVC_MAXPAGES from about 8 to about 256.  This
      means we need to be a bit careful about arrays of size RPCSVC_MAXPAGES.
      
      struct svc_rqst contains two such arrays.  However the there are never more
      that RPCSVC_MAXPAGES pages in the two arrays together, so only one array is
      needed.
      
      The two arrays are for the pages holding the request, and the pages holding
      the reply.  Instead of two arrays, we can simply keep an index into where the
      first reply page is.
      
      This patch also removes a number of small inline functions that probably
      server to obscure what is going on rather than clarify it, and opencode the
      needed functionality.
      
      Also remove the 'rq_restailpage' variable as it is *always* 0.  i.e.  if the
      response 'xdr' structure has a non-empty tail it is always in the same pages
      as the head.
      
       check counters are initilised and incr properly
       check for consistant usage of ++ etc
       maybe extra some inlines for common approach
       general review
      Signed-off-by: default avatarNeil Brown <neilb@suse.de>
      Cc: Magnus Maatta <novell@kiruna.se>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      44524359
  19. 20 Dec, 2005 1 commit
  20. 22 Jun, 2005 1 commit