1. 16 Mar, 2020 1 commit
  2. 09 Jul, 2019 1 commit
  3. 24 Apr, 2019 1 commit
  4. 29 Oct, 2018 1 commit
  5. 27 Nov, 2017 1 commit
  6. 17 Feb, 2017 1 commit
    • Kinglong Mee's avatar
      nfsd/idmap: return nfserr_inval for 0-length names · c3821b34
      Kinglong Mee authored
      Tigran Mkrtchyan's new pynfs testcases for zero length principals fail:
      SATT16   st_setattr.testEmptyPrincipal                            : FAILURE
                 Setting empty owner should return NFS4ERR_INVAL,
                 instead got NFS4ERR_BADOWNER
      SATT17   st_setattr.testEmptyGroupPrincipal                       : FAILURE
                 Setting empty owner_group should return NFS4ERR_INVAL,
                 instead got NFS4ERR_BADOWNER
      This patch checks the principal and returns nfserr_inval directly.  It
      could check after decoding in nfs4xdr.c, but it's simpler to do it in
      Signed-off-by: default avatarKinglong Mee <kinglongmee@gmail.com>
      Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
  7. 20 Jul, 2015 1 commit
  8. 03 Sep, 2014 2 commits
  9. 28 May, 2014 1 commit
    • J. Bruce Fields's avatar
      nfsd4: use xdr_reserve_space in attribute encoding · ddd1ea56
      J. Bruce Fields authored
      This is a cosmetic change for now; no change in behavior.
      Note we're just depending on xdr_reserve_space to do the bounds checking
      for us, we're not really depending on its adjustment of iovec or xdr_buf
      lengths yet, as those are fixed up by as necessary after the fact by
      read-link operations and by nfs4svc_encode_compoundres.  However we do
      have to update xdr->iov on read-like operations to prevent
      xdr_reserve_space from messing with the already-fixed-up length of the
      the head.
      When the attribute encoding fails partway through we have to undo the
      length adjustments made so far.  We do it manually for now, but later
      patches will add an xdr_truncate_encode() helper to handle cases like
      Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
  10. 08 Jan, 2014 1 commit
  11. 15 Feb, 2013 2 commits
  12. 13 Feb, 2013 2 commits
  13. 10 Sep, 2012 2 commits
  14. 27 Jul, 2012 1 commit
  15. 01 Jun, 2012 1 commit
  16. 12 Apr, 2012 3 commits
  17. 11 Apr, 2012 1 commit
  18. 28 Mar, 2012 1 commit
  19. 26 Mar, 2012 1 commit
    • J. Bruce Fields's avatar
      nfsd4: allow numeric idmapping · e9541ce8
      J. Bruce Fields authored
      Mimic the client side by providing a module parameter that turns off
      idmapping in the auth_sys case, for backwards compatibility with NFSv2
      and NFSv3.
      Unlike in the client case, we don't have any way to negotiate, since the
      client can return an error to us if it doesn't like the id that we
      return to it in (for example) a getattr call.
      However, it has always been possible for servers to return numeric id's,
      and as far as we're aware clients have always been able to handle them.
      Also, in the auth_sys case clients already need to have numeric id's the
      same between client and server.
      Therefore we believe it's safe to default this to on; but the module
      parameter is available to return to previous behavior if this proves to
      be a problem in some unexpected setup.
      Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
  20. 07 Dec, 2011 1 commit
  21. 07 Mar, 2011 1 commit
  22. 04 Jan, 2011 3 commits
  23. 21 Sep, 2010 1 commit
  24. 07 Sep, 2010 1 commit
  25. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      The script does the followings.
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
      The conversion was done in the following steps.
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
      6. percpu.h was updated not to include slab.h.
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
  26. 15 Dec, 2009 1 commit
  27. 14 Dec, 2009 1 commit
  28. 24 Sep, 2009 1 commit
  29. 09 Aug, 2009 2 commits
  30. 23 Apr, 2008 1 commit
    • Harvey Harrison's avatar
      nfsd: fix sparse warnings · a254b246
      Harvey Harrison authored
      Add extern to nfsd/nfsd.h
      fs/nfsd/nfssvc.c:146:5: warning: symbol 'nfsd_nrthreads' was not declared. Should it be static?
      fs/nfsd/nfssvc.c:261:5: warning: symbol 'nfsd_nrpools' was not declared. Should it be static?
      fs/nfsd/nfssvc.c:269:5: warning: symbol 'nfsd_get_nrthreads' was not declared. Should it be static?
      fs/nfsd/nfssvc.c:281:5: warning: symbol 'nfsd_set_nrthreads' was not declared. Should it be static?
      fs/nfsd/export.c:1534:23: warning: symbol 'nfs_exports_op' was not declared. Should it be static?
      Add include of auth.h
      fs/nfsd/auth.c:27:5: warning: symbol 'nfsd_setuser' was not declared. Should it be static?
      Make static, move forward declaration closer to where it's needed.
      fs/nfsd/nfs4state.c:1877:1: warning: symbol 'laundromat_main' was not declared. Should it be static?
      Make static, forward declaration was already marked static.
      fs/nfsd/nfs4idmap.c:206:1: warning: symbol 'idtoname_parse' was not declared. Should it be static?
      fs/nfsd/vfs.c:1156:1: warning: symbol 'nfsd_create_setattr' was not declared. Should it be static?
      Signed-off-by: default avatarHarvey Harrison <harvey.harrison@gmail.com>
      Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
  31. 01 Feb, 2008 1 commit