• Arnd Bergmann's avatar
    binfmt_misc: work around gcc-4.9 warning · de8288b1
    Arnd Bergmann authored
    gcc-4.9 on ARM gives us a mysterious warning about the binfmt_misc
    parse_command function:
      fs/binfmt_misc.c: In function 'parse_command.part.3':
      fs/binfmt_misc.c:405:7: warning: array subscript is above array bounds [-Warray-bounds]
    I've managed to trace this back to the ARM implementation of memset,
    which is called from copy_from_user in case of a fault and which does
     #define memset(p,v,n)                                                  \
            ({                                                              \
                    void *__p = (p); size_t __n = n;                        \
                    if ((__n) != 0) {                                       \
                            if (__builtin_constant_p((v)) && (v) == 0)      \
                                    __memzero((__p),(__n));                 \
                            else                                            \
                                    memset((__p),(v),(__n));                \
                    }                                                       \
                    (__p);                                                  \
    Apparently gcc gets confused by the check for "size != 0" and believes
    that the size might be zero when it gets to the line that does "if
    (s[count-1] == '\n')", so it would access data outside of the array.
    gcc is clearly wrong here, since this condition was already checked
    earlier in the function and the 'size' value can not change in the
    Fortunately, we can work around it and get rid of the warning by
    rearranging the function to check for zero size after doing the
    copy_from_user.  It is still safe to pass a zero size into
    copy_from_user, so it does not cause any side effects.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
binfmt_misc.c 15.3 KB