Skip to content
  • Arnd Bergmann's avatar
    x86/vdso: Change time() prototype to match __vdso_time() · 88edb57d
    Arnd Bergmann authored
    
    
    gcc-8 warns that time() is an alias for __vdso_time() but the two
    have different prototypes:
    
      arch/x86/entry/vdso/vclock_gettime.c:327:5: error: 'time' alias between functions of incompatible types 'int(time_t *)' {aka 'int(long int *)'} and 'time_t(time_t *)' {aka 'long int(long int *)'} [-Werror=attribute-alias]
       int time(time_t *t)
           ^~~~
      arch/x86/entry/vdso/vclock_gettime.c:318:16: note: aliased declaration here
    
    I could not figure out whether this is intentional, but I see that
    changing it to return time_t avoids the warning.
    
    Returning 'int' from time() is also a bit questionable, as it causes an
    overflow in y2038 even on 64-bit architectures that use a 64-bit time_t
    type. On 32-bit architecture with 64-bit time_t, time() should always
    be implement by the C library by calling a (to be added) clock_gettime()
    variant that takes a sufficiently wide argument.
    
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
    Link: http://lkml.kernel.org/r/20171204150203.852959-1-arnd@arndb.de
    
    
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    88edb57d