• Arnd Bergmann's avatar
    ACPI / watchdog: properly initialize resources · 6ce14f64
    Arnd Bergmann authored
    We copy a local resource structure into a list, but only
    initialize some of its members, as pointed out by gcc-4.4:
    
    drivers/acpi/acpi_watchdog.c: In function 'acpi_watchdog_init':
    drivers/acpi/acpi_watchdog.c:105: error: 'res.child' may be used uninitialized in this function
    drivers/acpi/acpi_watchdog.c:105: error: 'res.sibling' may be used uninitialized in this function
    drivers/acpi/acpi_watchdog.c:105: error: 'res.parent' may be used uninitialized in this function
    drivers/acpi/acpi_watchdog.c:105: error: 'res.desc' may be used uninitialized in this function
    drivers/acpi/acpi_watchdog.c:105: error: 'res.name' may be used uninitialized in this function
    
    Newer compilers can presumably optimize the uninitialized access
    away entirely and don't warn at all, but rely on the kzalloc()
    to zero the structure first. This adds an explicit initialization
    to force consistent behavior.
    
    Fixes: 058dfc76 (ACPI / watchdog: Add support for WDAT hardware watchdog)
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    6ce14f64