Skip to content
  • Jules Irenge's avatar
    fsnotify: Add missing annotation for fsnotify_finish_user_wait() and for... · 00e0afb6
    Jules Irenge authored
    fsnotify: Add missing annotation for fsnotify_finish_user_wait() and for fsnotify_prepare_user_wait()
    
    Sparse reports warnings at fsnotify_prepare_user_wait()
    	and at fsnotify_finish_user_wait()
    
    warning: context imbalance in fsnotify_finish_user_wait()
    	- wrong count at exit
    warning: context imbalance in fsnotify_prepare_user_wait()
    	- unexpected unlock
    
    The root cause is the missing annotation at fsnotify_finish_user_wait()
    	and at fsnotify_prepare_user_wait()
    fsnotify_prepare_user_wait() has an extra annotation __release()
     that only tell Sparse and not GCC to shutdown the warning
    
    Add the missing  __acquires(&fsnotify_mark_srcu) annotation
    Add the missing __releases(&fsnotify_mark_srcu) annotation
    Add the __release(&fsnotify_mark_srcu) annotation.
    
    Link: https://lore.kernel.org/r/20200413214240.15245-1-jbi.octave@gmail.com
    
    
    Signed-off-by: default avatarJules Irenge <jbi.octave@gmail.com>
    Signed-off-by: default avatarJan Kara <jack@suse.cz>
    00e0afb6