Commit 0dd99ca7 authored by LiFan's avatar LiFan Committed by Jaegeuk Kim

f2fs: validate before set/clear free nat bitmap

In flush_nat_entries, all dirty nats will be flushed and if
their new address isn't NULL_ADDR, their bitmaps will be updated,
the free_nid_count of the bitmaps will be increaced regardless
of whether the nats have already been occupied before.
This could lead to wrong free_nid_count.
So this patch checks the status of the bits beforeactually
set/clear them.

Fixes: 586d1492 ("f2fs: skip scanning free nid bitmap of full NAT blocks")
Signed-off-by: default avatarFan li <>
Reviewed-by: default avatarChao Yu <>
Signed-off-by: default avatarJaegeuk Kim <>
parent 19526d74
......@@ -1906,15 +1906,18 @@ static void update_free_nid_bitmap(struct f2fs_sb_info *sbi, nid_t nid,
if (!test_bit_le(nat_ofs, nm_i->nat_block_bitmap))
if (set)
if (set) {
if (test_bit_le(nid_ofs, nm_i->free_nid_bitmap[nat_ofs]))
__set_bit_le(nid_ofs, nm_i->free_nid_bitmap[nat_ofs]);
__clear_bit_le(nid_ofs, nm_i->free_nid_bitmap[nat_ofs]);
if (set)
else if (!build)
} else {
if (!test_bit_le(nid_ofs, nm_i->free_nid_bitmap[nat_ofs]))
__clear_bit_le(nid_ofs, nm_i->free_nid_bitmap[nat_ofs]);
if (!build)
static void scan_nat_page(struct f2fs_sb_info *sbi,
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment