Commit 9cf29399 authored by Dave Airlie's avatar Dave Airlie Committed by Alex Deucher

amdgpu/dc: make opp construct void.

This doesn't return anything except true.
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent c60ae112
......@@ -540,7 +540,7 @@ static const struct opp_funcs funcs = {
.opp_program_bit_depth_reduction = dce110_opp_program_bit_depth_reduction
};
bool dce110_opp_construct(struct dce110_opp *opp110,
void dce110_opp_construct(struct dce110_opp *opp110,
struct dc_context *ctx,
uint32_t inst,
const struct dce_opp_registers *regs,
......@@ -556,8 +556,6 @@ bool dce110_opp_construct(struct dce110_opp *opp110,
opp110->regs = regs;
opp110->opp_shift = opp_shift;
opp110->opp_mask = opp_mask;
return true;
}
void dce110_opp_destroy(struct output_pixel_processor **opp)
......
......@@ -272,7 +272,7 @@ struct dce110_opp {
const struct dce_opp_mask *opp_mask;
};
bool dce110_opp_construct(struct dce110_opp *opp110,
void dce110_opp_construct(struct dce110_opp *opp110,
struct dc_context *ctx,
uint32_t inst,
const struct dce_opp_registers *regs,
......
......@@ -547,13 +547,9 @@ struct output_pixel_processor *dce100_opp_create(
if (!opp)
return NULL;
if (dce110_opp_construct(opp,
ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask))
return &opp->base;
BREAK_TO_DEBUGGER();
kfree(opp);
return NULL;
dce110_opp_construct(opp,
ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask);
return &opp->base;
}
struct clock_source *dce100_clock_source_create(
......
......@@ -586,13 +586,9 @@ static struct output_pixel_processor *dce110_opp_create(
if (!opp)
return NULL;
if (dce110_opp_construct(opp,
ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask))
return &opp->base;
BREAK_TO_DEBUGGER();
kfree(opp);
return NULL;
dce110_opp_construct(opp,
ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask);
return &opp->base;
}
struct clock_source *dce110_clock_source_create(
......
......@@ -586,13 +586,9 @@ struct output_pixel_processor *dce112_opp_create(
if (!opp)
return NULL;
if (dce110_opp_construct(opp,
ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask))
return &opp->base;
BREAK_TO_DEBUGGER();
kfree(opp);
return NULL;
dce110_opp_construct(opp,
ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask);
return &opp->base;
}
struct clock_source *dce112_clock_source_create(
......
......@@ -356,13 +356,9 @@ struct output_pixel_processor *dce120_opp_create(
if (!opp)
return NULL;
if (dce110_opp_construct(opp,
ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask))
return &opp->base;
BREAK_TO_DEBUGGER();
kfree(opp);
return NULL;
dce110_opp_construct(opp,
ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask);
return &opp->base;
}
static const struct bios_registers bios_regs = {
......
......@@ -422,13 +422,9 @@ static struct output_pixel_processor *dce80_opp_create(
if (!opp)
return NULL;
if (dce110_opp_construct(opp,
ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask))
return &opp->base;
BREAK_TO_DEBUGGER();
kfree(opp);
return NULL;
dce110_opp_construct(opp,
ctx, inst, &opp_regs[inst], &opp_shift, &opp_mask);
return &opp->base;
}
static struct stream_encoder *dce80_stream_encoder_create(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment