Commit a27f6ef4 authored by Eryu Guan's avatar Eryu Guan Committed by Dave Chinner

xfs: undo block reservation correctly in xfs_trans_reserve()

"blocks" should be added back to fdblocks at undo time, not taken
away, i.e. the minus sign should not be used.

This is a regression introduced by commit 0d485ada ("xfs: use
generic percpu counters for free block counter"). And it's found by
code inspection, I didn't it in real world, so there's no
Signed-off-by: default avatarEryu Guan <>
Reviewed-by: default avatarDave Chinner <>
Signed-off-by: default avatarDave Chinner <>
parent ea78d808
......@@ -217,7 +217,7 @@ xfs_trans_reserve(
if (blocks > 0) {
xfs_mod_fdblocks(tp->t_mountp, -((int64_t)blocks), rsvd);
xfs_mod_fdblocks(tp->t_mountp, (int64_t)blocks, rsvd);
tp->t_blk_res = 0;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment