1. 30 Nov, 2017 1 commit
  2. 02 Nov, 2017 1 commit
    • Greg Kroah-Hartman's avatar
      License cleanup: add SPDX GPL-2.0 license identifier to files with no license · b2441318
      Greg Kroah-Hartman authored
      Many source files in the tree are missing licensing information, which
      makes it harder for compliance tools to determine the correct license.
      By default all files without license information are under the default
      license of the kernel, which is GPL version 2.
      Update the files which contain no license information with the 'GPL-2.0'
      SPDX license identifier.  The SPDX identifier is a legally binding
      shorthand, which can be used instead of the full boiler plate text.
      This patch is based on work done by Thomas Gleixner and Kate Stewart and
      Philippe Ombredanne.
      How this work was done:
      Patches were generated and checked against linux-4.14-rc6 for a subset of
      the use cases:
       - file had no licensing information it it.
       - file was a */uapi/* one with no licensing information in it,
       - file was a */uapi/* one with existing licensing information,
      Further patches will be generated in subsequent months to fix up cases
      where non-standard license headers were used, and references to license
      had to be inferred by heuristics based on keywords.
      The analysis to determine which SPDX License Identifier to be applied to
      a file was done in a spreadsheet of side by side results from of the
      output of two independent scanners (ScanCode & Windriver) producing SPDX
      tag:value files created by Philippe Ombredanne.  Philippe prepared the
      base worksheet, and did an initial spot review of a few 1000 files.
      The 4.13 kernel was the starting point of the analysis with 60,537 files
      assessed.  Kate Stewart did a file by file comparison of the scanner
      results in the spreadsheet to determine which SPDX license identifier(s)
      to be applied to the file. She confirmed any determination that was not
      immediately clear with lawyers working with the Linux Foundation.
      Criteria used to select files for SPDX license identifier tagging was:
       - Files considered eligible had to be source code files.
       - Make and config files were included as candidates if they contained >5
         lines of source
       - File already had some variant of a license header in it (even if <5
      All documentation files were explicitly excluded.
      The following heuristics were used to determine which SPDX license
      identifiers to apply.
       - when both scanners couldn't find any license traces, file was
         considered to have no license information in it, and the top level
         COPYING file license applied.
         For non */uapi/* files that summary was:
         SPDX license identifier                            # files
         GPL-2.0                                              11139
         and resulted in the first patch in this series.
         If that file was a */uapi/* path one, it was "GPL-2.0 WITH
         Linux-syscall-note" otherwise it was "GPL-2.0".  Results of that was:
         SPDX license identifier                            # files
         GPL-2.0 WITH Linux-syscall-note                        930
         and resulted in the second patch in this series.
       - if a file had some form of licensing information in it, and was one
         of the */uapi/* ones, it was denoted with the Linux-syscall-note if
         any GPL family license was found in the file or had no licensing in
         it (per prior point).  Results summary:
         SPDX license identifier                            # files
         GPL-2.0 WITH Linux-syscall-note                       270
         GPL-2.0+ WITH Linux-syscall-note                      169
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause)    21
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)    17
         LGPL-2.1+ WITH Linux-syscall-note                      15
         GPL-1.0+ WITH Linux-syscall-note                       14
         ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause)    5
         LGPL-2.0+ WITH Linux-syscall-note                       4
         LGPL-2.1 WITH Linux-syscall-note                        3
         ((GPL-2.0 WITH Linux-syscall-note) OR MIT)              3
         ((GPL-2.0 WITH Linux-syscall-note) AND MIT)             1
         and that resulted in the third patch in this series.
       - when the two scanners agreed on the detected license(s), that became
         the concluded license(s).
       - when there was disagreement between the two scanners (one detected a
         license but the other didn't, or they both detected different
         licenses) a manual inspection of the file occurred.
       - In most cases a manual inspection of the information in the file
         resulted in a clear resolution of the license that should apply (and
         which scanner probably needed to revisit its heuristics).
       - When it was not immediately clear, the license identifier was
         confirmed with lawyers working with the Linux Foundation.
       - If there was any question as to the appropriate license identifier,
         the file was flagged for further research and to be revisited later
         in time.
      In total, over 70 hours of logged manual review was done on the
      spreadsheet to determine the SPDX license identifiers to apply to the
      source files by Kate, Philippe, Thomas and, in some cases, confirmation
      by lawyers working with the Linux Foundation.
      Kate also obtained a third independent scan of the 4.13 code base from
      FOSSology, and compared selected files where the other two scanners
      disagreed against that SPDX file, to see if there was new insights.  The
      Windriver scanner is based on an older version of FOSSology in part, so
      they are related.
      Thomas did random spot checks in about 500 files from the spreadsheets
      for the uapi headers and agreed with SPDX license identifier in the
      files he inspected. For the non-uapi files Thomas did random spot checks
      in about 15000 files.
      In initial set of patches against 4.14-rc6, 3 files were found to have
      copy/paste license identifier errors, and have been fixed to reflect the
      correct identifier.
      Additionally Philippe spent 10 hours this week doing a detailed manual
      inspection and review of the 12,461 patched files from the initial patch
      version early this week with:
       - a full scancode scan run, collecting the matched texts, detected
         license ids and scores
       - reviewing anything where there was a license detected (about 500+
         files) to ensure that the applied SPDX license was correct
       - reviewing anything where there was no detection but the patch license
         was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
         SPDX license was correct
      This produced a worksheet with 20 files needing minor correction.  This
      worksheet was then exported into 3 different .csv files for the
      different types of files to be modified.
      These .csv files were then reviewed by Greg.  Thomas wrote a script to
      parse the csv files and add the proper SPDX tag to the file, in the
      format that the file expected.  This script was further refined by Greg
      based on the output to detect more types of files automatically and to
      distinguish between header and source .c files (which need different
      comment types.)  Finally Greg ran the script using the .csv files to
      generate the patches.
      Reviewed-by: default avatarKate Stewart <kstewart@linuxfoundation.org>
      Reviewed-by: default avatarPhilippe Ombredanne <pombredanne@nexb.com>
      Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
  3. 04 Oct, 2017 1 commit
  4. 31 Aug, 2017 1 commit
    • Nobuo Iwata's avatar
      usbip: auto retry for concurrent attach · a38711a8
      Nobuo Iwata authored
      This patch adds recovery from false busy state on concurrent attach
      The procedure of attach operation is as below.
      1) Find an unused port in /sys/devices/platform/vhci_hcd/status.
      2) Request attach found port to driver through
      /sys/devices/platform/vhci_hcd/attach. (userspace)
      3) Lock table, reserve requested port and unlock table. (vhci driver)
      Attaching more than one remote devices concurrently, same unused port
      number will be found in step-1. Then one request will succeed and
      others will fail even though there are some unused ports.
      With this patch, driver returns EBUSY when requested port has already
      been used. In this case, attach command retries from step-1: finding
      another unused port. If there's no unused port, the attach operation
      will fail in step-1. Otherwise it retries automatically using another
      unused port.
      vhci-hcd's interface (only errno) is changed as following.
      Current	errno	New errno	Condition
      EINVAL		same as left	specified port number is in invalid
      EAGAIN		same as left	platform_get_drvdata() failed
      EINVAL		same as left	specified socket fd is not valid
      EINVAL		EBUSY		specified port status is not free
      The errno EBUSY was not used in userspace
      src/usbip_attach.c:import_device(). It is needed to distinguish the
      condition to be able to retry from other unrecoverable errors.
      It is possible to avoid this failure by introducing userspace exclusive
      control. But it's exaggerated for this special condition. The locking
      itself has done in driver.
      As an alternate solution, userspace doesn't specify port number, driver
      searches unused port and it returns port number to the userspace. With
      this solution, the interface is much different than this patch.
      Signed-off-by: default avatarNobuo Iwata <nobuo.iwata@fujixerox.co.jp>
      Acked-by: default avatarShuah Khan <shuahkh@osg.samsung.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
  5. 13 Jun, 2017 6 commits
  6. 02 Jun, 2017 1 commit
  7. 18 Apr, 2017 1 commit
  8. 11 Apr, 2017 1 commit
  9. 08 Apr, 2017 1 commit
  10. 17 Mar, 2017 2 commits
  11. 16 Mar, 2017 1 commit
  12. 24 Jan, 2017 2 commits
  13. 10 Jan, 2017 2 commits
  14. 06 Dec, 2016 1 commit
  15. 07 Nov, 2016 1 commit
    • Nobuo Iwata's avatar
      usbip: deletion of incorrect socket descriptor checking · 220c61b6
      Nobuo Iwata authored
      This patch removes checking of socket descriptor value in daemons.
      It was checked to be less than FD_SETSIZE(1024 usually) but it's not
      To be exact, the maximum value of descriptor comes from
      Following kernel code determines the value :
          get_unused_fd_flags() : fs/files.c
          __alloc_fd() : fs/files.c
          expand_files() : fs/files.c
      The defalut (soft limit) is defines as INR_OPEN_CUR(1024) in
      include/linux/fs.h which is referenced form INIT_RLIMS in
      include/asm-generic/resource.h. The value may be modified with ulimt,
      sysctl, security configuration and etc.
      With the kernel code above, when socket() system call returns positive
      value, the value must be within rlimit(RLIMIT_NOFILE). No extra
      checking is needed when socket() returns positive.
      Without 'usbip: vhci number of ports extension' patch set, there's no
      practical problem because of number of USB port restriction. With the
      patch set, the value of socket descriptor can exceed FD_SETSIZE(1024
      usually) if the rlimit is changed.
      Signed-off-by: default avatarNobuo Iwata <nobuo.iwata@fujixerox.co.jp>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
  16. 03 May, 2016 1 commit
  17. 26 Apr, 2016 3 commits
  18. 27 Sep, 2015 2 commits
  19. 22 Sep, 2015 1 commit
  20. 15 Jan, 2015 1 commit
  21. 12 Jan, 2015 1 commit
  22. 03 Dec, 2014 1 commit
  23. 20 Nov, 2014 2 commits
  24. 04 Sep, 2014 1 commit
  25. 02 Sep, 2014 2 commits
  26. 25 Aug, 2014 1 commit
  27. 30 Jun, 2014 1 commit