HDMI RX Support

V4l2-compliance test result :-

root@debian-rockchip-rock5b-rk3588:~# v4l2-compliance -d /dev/video0
v4l2-compliance 1.27.0-5163, 64 bits, 64-bit time_t
v4l2-compliance SHA: f105c1eff034 2023-12-20 16:29:11

Compliance test for rk_hdmirx device /dev/video0:

Driver Info:
	Driver name      : rk_hdmirx
	Card type        : rk_hdmirx
	Bus info         : platform: fdee0000.hdmirx-contr
	Driver version   : 6.7.0
	Capabilities     : 0x84201000
		Video Capture Multiplanar
		Streaming
		Extended Pix Format
		Device Capabilities
	Device Caps      : 0x04201000
		Video Capture Multiplanar
		Streaming
		Extended Pix Format

Required ioctls:
	test VIDIOC_QUERYCAP: OK
	test invalid ioctls: OK

Allow for multiple opens:
	test second /dev/video0 open: OK
	test VIDIOC_QUERYCAP: OK
	test VIDIOC_G/S_PRIORITY: OK
	test for unlimited opens: OK

Debug ioctls:
	test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
	test VIDIOC_LOG_STATUS: OK

Input ioctls:
	test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
	test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
	test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
	test VIDIOC_ENUMAUDIO: OK (Not Supported)
	test VIDIOC_G/S/ENUMINPUT: OK
	test VIDIOC_G/S_AUDIO: OK (Not Supported)
	Inputs: 1 Audio Inputs: 0 Tuners: 0

Output ioctls:
	test VIDIOC_G/S_MODULATOR: OK (Not Supported)
	test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
	test VIDIOC_ENUMAUDOUT: OK (Not Supported)
	test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
	test VIDIOC_G/S_AUDOUT: OK (Not Supported)
	Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
	test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
		fail: v4l2-test-io-config.cpp(210): field == V4L2_FIELD_NONE
		fail: v4l2-test-io-config.cpp(386): Timings check failed for input 0.
	test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: FAIL
	test VIDIOC_DV_TIMINGS_CAP: OK
	test VIDIOC_G/S_EDID: OK

Control ioctls (Input 0):
	test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
	test VIDIOC_QUERYCTRL: OK
	test VIDIOC_G/S_CTRL: OK
	test VIDIOC_G/S/TRY_EXT_CTRLS: OK
	test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
	test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
	Standard Controls: 2 Private Controls: 0

Format ioctls (Input 0):
	test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
	test VIDIOC_G/S_PARM: OK (Not Supported)
	test VIDIOC_G_FBUF: OK (Not Supported)
	test VIDIOC_G_FMT: OK
	test VIDIOC_TRY_FMT: OK
	test VIDIOC_S_FMT: OK
	test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
	test Cropping: OK (Not Supported)
	test Composing: OK (Not Supported)
	test Scaling: OK (Not Supported)

Codec ioctls (Input 0):
	test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
	test VIDIOC_G_ENC_INDEX: OK (Not Supported)
	test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls (Input 0):
		fail: v4l2-test-buffers.cpp(679): doioctl(node, VIDIOC_REQBUFS, &reqbufs)
	test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL
	test CREATE_BUFS maximum buffers: OK
	test VIDIOC_EXPBUF: OK
	test Requests: OK (Not Supported)

Total for rk_hdmirx device /dev/video0: 46, Succeeded: 44, Failed: 2, Warnings: 0

Normally you can set dev and queue locks so that this extra locking would not be needed, see calls to v4l2_ioctl_get_lock(). It can perhaps slim down a bit your driver.

will make the change in v2

I don't see any enum_frmsize and enum_frame_interval implementation, its a nice to have for this type of driver.

Note that this is a partial drive-by review, with aim to spot the S/G_FMT issues reported by the compliance.

added 2 commits

• e05b428a - media: platform: synopsys: Add support for hdmi input driver
• 898b52e3 - dt-bindings: media: Document bindings for HDMI RX Controller

Compare with previous version

added 15304 commits

• 898b52e3...ccfac401 - 15299 commits from branch hardware-enablement/rockchip-3588:rk3588
• 89c13f03 - clk: rockchip: rst-rk3588: Add BIU reset
• 9f405aec - arm64: dts: rockchip: Add device tree support for HDMI RX Controller
• 39e06866 - media: platform: synopsys: Add support for hdmi input driver
• 01144c56 - dt-bindings: media: Document bindings for HDMI RX Controller
• 3f2f4d06 - Testing

Compare with previous version

added 2 commits

• 9eea9bf5 - media: platform: synopsys: Add support for hdmi input driver
• 92c64176 - dt-bindings: media: Document bindings for HDMI RX Controller

Compare with previous version

added 2 commits

• 5ddc8f79 - media: platform: synopsys: Add support for hdmi input driver
• 28d08525 - dt-bindings: media: Document bindings for HDMI RX Controller

Compare with previous version

added 1 commit

• ab654740 - Testing

Compare with previous version

added 20 commits

• f682bd60...060eada7 - 19 commits from branch hardware-enablement/rockchip-3588:rk3588
• 3aed4822 - Merge branch linux:rk3588 into rk3588-hdmirx-v3

Compare with previous version

added 2 commits

• e92f0e5a - media: platform: synopsys: Add support for hdmi input driver
• 684b1a38 - dt-bindings: media: Document bindings for HDMI RX Controller

Compare with previous version