Skip to content
  • Frederic Weisbecker's avatar
    timer: Fix bad idle check on irq entry · 0a8a2e78
    Frederic Weisbecker authored
    
    
    idle_cpu() is called on irq entry to guess if we need to call
    tick_check_idle(). This way we can catch up with jiffies if the tick
    was stopped, stop accounting idle time during the interrupt and
    maintain the sched clock if it is unstable.
    
    But if we are going to exit the idle loop to schedule a new task (ie:
    if we have a task in the runqueue or a remotely enqueued ttwu to
    perform), the idle_cpu() check will return 0 such that we miss the
    call to tick_check_idle() for all interrupts happening before we
    schedule the new task.
    
    As a result these interrupts and the softirqs coming along may deal
    with stale jiffies values, bad sched clock values, and won't substract
    their time from the idle time accounting.
    
    Fix this with using is_idle_task() instead that strictly checks that
    we are running the idle task, without caring about the fact we are
    going to schedule a task soon.
    
    Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: John Stultz <john.stultz@linaro.org>
    Cc: Ingo Molnar <mingo@elte.hu>
    Link: http://lkml.kernel.org/r/1327427984-23282-3-git-send-email-fweisbec@gmail.com
    
    
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    0a8a2e78