Commit 77c5f5d2 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab

ghes_edac: Register at EDAC core the BIOS report

Register GHES at EDAC MC core, in order to avoid other
drivers to also handle errors and mangle with error data.

The edac core will warrant that just one driver will be used,
so the first one to register (BIOS first) will be the one that
will be reporting the hardware errors.

For now, the EDAC driver does nothing but to register at the
EDAC core, preventing the hardware-driven mechanism to
interfere with GHES.
Signed-off-by: default avatarMauro Carvalho Chehab <>
parent 21480547
......@@ -2803,6 +2803,13 @@ W:
S: Maintained
F: drivers/edac/e7xxx_edac.c
M: Mauro Carvalho Chehab <>
S: Maintained
F: drivers/edac/ghes-edac.c
M: Tim Small <>
......@@ -80,6 +80,29 @@ config EDAC_MM_EDAC
occurred so that a particular failing memory module can be
replaced. If unsure, select 'Y'.
config EDAC_GHES
bool "Output ACPI APEI/GHES BIOS detected errors via EDAC"
depends on ACPI_APEI_GHES && (EDAC_MM_EDAC=y)
default y
Not all machines support hardware-driven error report. Some of those
provide a BIOS-driven error report mechanism via ACPI, using the
APEI/GHES driver. By enabling this option, the error reports provided
by GHES are sent to userspace via the EDAC API.
When this option is enabled, it will disable the hardware-driven
mechanisms, if a GHES BIOS is detected, entering into the
"Firmware First" mode.
It should be noticed that keeping both GHES and a hardware-driven
error mechanism won't work well, as BIOS will race with OS, while
reading the error registers. So, if you want to not use "Firmware
first" GHES error mechanism, you should disable GHES either at
compilation time or by passing "ghes.disable=1" Kernel parameter
at boot time.
In doubt, say 'Y'.
config EDAC_AMD64
tristate "AMD64 (Opteron, Athlon64) K8, F10h"
depends on EDAC_MM_EDAC && AMD_NB && X86_64 && EDAC_DECODE_MCE
......@@ -16,6 +16,7 @@ ifdef CONFIG_PCI
edac_core-y += edac_pci.o edac_pci_sysfs.o
obj-$(CONFIG_EDAC_GHES) += ghes_edac.o
obj-$(CONFIG_EDAC_MCE_INJ) += mce_amd_inj.o
edac_mce_amd-y := mce_amd.o
* GHES/EDAC Linux driver
* This file may be distributed under the terms of the GNU General Public
* License version 2.
* Copyright (c) 2013 by Mauro Carvalho Chehab <>
* Red Hat Inc.
#include <acpi/ghes.h>
#include <linux/edac.h>
#include "edac_core.h"
#define GHES_PFX "ghes_edac: "
#define GHES_EDAC_REVISION " Ver: 1.0.0"
struct ghes_edac_pvt {
struct list_head list;
struct ghes *ghes;
struct mem_ctl_info *mci;
static LIST_HEAD(ghes_reglist);
static DEFINE_MUTEX(ghes_edac_lock);
static int ghes_edac_mc_num;
void ghes_edac_report_mem_error(struct ghes *ghes, int sev,
struct cper_sec_mem_err *mem_err)
int ghes_edac_register(struct ghes *ghes, struct device *dev)
int rc;
struct mem_ctl_info *mci;
struct edac_mc_layer layers[1];
struct csrow_info *csrow;
struct dimm_info *dimm;
struct ghes_edac_pvt *pvt;
layers[0].type = EDAC_MC_LAYER_ALL_MEM;
layers[0].size = 1;
layers[0].is_virt_csrow = true;
* We need to serialize edac_mc_alloc() and edac_mc_add_mc(),
* to avoid duplicated memory controller numbers
mci = edac_mc_alloc(ghes_edac_mc_num, ARRAY_SIZE(layers), layers,
if (!mci) {
pr_info(GHES_PFX "Can't allocate memory for EDAC data\n");
return -ENOMEM;
pvt = mci->pvt_info;
memset(pvt, 0, sizeof(*pvt));
list_add_tail(&pvt->list, &ghes_reglist);
pvt->ghes = ghes;
pvt->mci = mci;
mci->pdev = dev;
mci->mtype_cap = MEM_FLAG_EMPTY;
mci->edac_ctl_cap = EDAC_FLAG_NONE;
mci->edac_cap = EDAC_FLAG_NONE;
mci->mod_name = "ghes_edac.c";
mci->mod_ver = GHES_EDAC_REVISION;
mci->ctl_name = "ghes_edac";
mci->dev_name = "ghes";
csrow = mci->csrows[0];
dimm = csrow->channels[0]->dimm;
dimm->nr_pages = 1000;
dimm->grain = 128;
dimm->mtype = MEM_UNKNOWN;
dimm->dtype = DEV_UNKNOWN;
dimm->edac_mode = EDAC_SECDED;
rc = edac_mc_add_mc(mci);
if (rc < 0) {
pr_info(GHES_PFX "Can't register at EDAC core\n");
return -ENODEV;
return 0;
void ghes_edac_unregister(struct ghes *ghes)
struct mem_ctl_info *mci;
struct ghes_edac_pvt *pvt;
list_for_each_entry(pvt, &ghes_reglist, list) {
if (ghes == pvt->ghes) {
mci = pvt->mci;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment