Commit 83f1b4ba authored by Linus Torvalds's avatar Linus Torvalds Committed by David S. Miller
Browse files

net: fix incorrect credentials passing

Commit 257b5358

 ("scm: Capture the full credentials of the scm
sender") changed the credentials passing code to pass in the effective
uid/gid instead of the real uid/gid.

Obviously this doesn't matter most of the time (since normally they are
the same), but it results in differences for suid binaries when the wrong
uid/gid ends up being used.

This just undoes that (presumably unintentional) part of the commit.
Reported-by: default avatarAndy Lutomirski <>
Cc: Eric W. Biederman <>
Cc: Serge E. Hallyn <>
Cc: David S. Miller <>
Signed-off-by: default avatarLinus Torvalds <>
Acked-by: default avatar"Eric W. Biederman" <>
Signed-off-by: default avatarDavid S. Miller <>
parent c846ad9b
......@@ -56,8 +56,8 @@ static __inline__ void scm_set_cred(struct scm_cookie *scm,
scm->pid = get_pid(pid);
scm->cred = cred ? get_cred(cred) : NULL;
scm-> = pid_vnr(pid);
scm->creds.uid = cred ? cred->euid : INVALID_UID;
scm->creds.gid = cred ? cred->egid : INVALID_GID;
scm->creds.uid = cred ? cred->uid : INVALID_UID;
scm->creds.gid = cred ? cred->gid : INVALID_GID;
static __inline__ void scm_destroy_cred(struct scm_cookie *scm)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment