Skip to content
  • Eric Dumazet's avatar
    net: gro: add a per device gro flush timer · 3b47d303
    Eric Dumazet authored
    
    
    Tuning coalescing parameters on NIC can be really hard.
    
    Servers can handle both bulk and RPC like traffic, with conflicting
    goals : bulk flows want as big GRO packets as possible, RPC want minimal
    latencies.
    
    To reach big GRO packets on 10Gbe NIC, one can use :
    
    ethtool -C eth0 rx-usecs 4 rx-frames 44
    
    But this penalizes rpc sessions, with an increase of latencies, up to
    50% in some cases, as NICs generally do not force an interrupt when
    a packet with TCP Push flag is received.
    
    Some NICs do not have an absolute timer, only a timer rearmed for every
    incoming packet.
    
    This patch uses a different strategy : Let GRO stack decides what do do,
    based on traffic pattern.
    
    Packets with Push flag wont be delayed.
    Packets without Push flag might be held in GRO engine, if we keep
    receiving data.
    
    This new mechanism is off by default, and shall be enabled by setting
    /sys/class/net/ethX/gro_flush_timeout to a value in nanosecond.
    
    To fully enable this mechanism, drivers should use napi_complete_done()
    instead of napi_complete().
    
    Tested:
     Ran 200 netperf TCP_STREAM from A to B (10Gbe mlx4 link, 8 RX queues)
    
    Without this feature, we send back about 305,000 ACK per second.
    
    GRO aggregation ratio is low (811/305 = 2.65 segments per GRO packet)
    
    Setting a timer of 2000 nsec is enough to increase GRO packet sizes
    and reduce number of ACK packets. (811/19.2 = 42)
    
    Receiver performs less calls to upper stacks, less wakes up.
    This also reduces cpu usage on the sender, as it receives less ACK
    packets.
    
    Note that reducing number of wakes up increases cpu efficiency, but can
    decrease QPS, as applications wont have the chance to warmup cpu caches
    doing a partial read of RPC requests/answers if they fit in one skb.
    
    B:~# sar -n DEV 1 10 | grep eth0 | tail -1
    Average:         eth0 811269.80 305732.30 1199462.57  19705.72      0.00
    0.00      0.50
    
    B:~# echo 2000 >/sys/class/net/eth0/gro_flush_timeout
    
    B:~# sar -n DEV 1 10 | grep eth0 | tail -1
    Average:         eth0 811577.30  19230.80 1199916.51   1239.80      0.00
    0.00      0.50
    
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    3b47d303