-
- Downloads
ALSA: hda: Refactor display power management
The current HD-audio code manages the DRM audio power via too complex redirections, and this seems even still unbalanced in a corner case as Intel DRM CI has been intermittently reporting. This patch is a big surgery for addressing the complexity and the possible unbalance. Basically the patch changes the display PM in the following ways: - Both HD-audio controller and codec drivers call a single helper, snd_hdac_display_power(). (Formerly, the display power control from a codec was done indirectly via link_power bus ops.) - snd_hdac_display_power() receives the codec address index. For turning on/off from the controller, pass HDA_CODEC_IDX_CONTROLLER. - snd_hdac_display_power() doesn't manage refcounts any longer, but keeps the power status in bitmap. If any of controller or codecs is turned on, the function updates the DRM power state via get_power() or put_power(). Also this refactor allows us more cleanup: - The link_power bus ops is dropped, so there is no longer indirect management, as mentioned in the above. - hdac_device link_power_control flag is moved to hda_codec display_power_control flag, as it's only for HDA legacy. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106525 Signed-off-by:Takashi Iwai <tiwai@suse.de>
Showing
- include/sound/hda_codec.h 1 addition, 0 deletionsinclude/sound/hda_codec.h
- include/sound/hda_component.h 8 additions, 2 deletionsinclude/sound/hda_component.h
- include/sound/hdaudio.h 2 additions, 5 deletionsinclude/sound/hdaudio.h
- sound/hda/hdac_component.c 22 additions, 13 deletionssound/hda/hdac_component.c
- sound/hda/hdac_device.c 0 additions, 17 deletionssound/hda/hdac_device.c
- sound/pci/hda/hda_codec.c 12 additions, 4 deletionssound/pci/hda/hda_codec.c
- sound/pci/hda/hda_controller.c 0 additions, 11 deletionssound/pci/hda/hda_controller.c
- sound/pci/hda/hda_intel.c 8 additions, 14 deletionssound/pci/hda/hda_intel.c
- sound/pci/hda/patch_hdmi.c 2 additions, 2 deletionssound/pci/hda/patch_hdmi.c
- sound/soc/codecs/hdac_hdmi.c 3 additions, 4 deletionssound/soc/codecs/hdac_hdmi.c
- sound/soc/intel/skylake/skl.c 5 additions, 5 deletionssound/soc/intel/skylake/skl.c
Loading
Please register or sign in to comment