-
- Downloads
iscsi-target: Add login_keys_workaround attribute for non RFC initiators
This patch re-introduces part of a long standing login workaround that was recently dropped by: commit 1c99de98 Author: Nicholas Bellinger <nab@linux-iscsi.org> Date: Sun Apr 2 13:36:44 2017 -0700 iscsi-target: Drop work-around for legacy GlobalSAN initiator Namely, the workaround for FirstBurstLength ended up being required by Mellanox Flexboot PXE boot ROMs as reported by Robert. So this patch re-adds the work-around for FirstBurstLength within iscsi_check_proposer_for_optional_reply(), and makes the key optional to respond when the initiator does not propose, nor respond to it. Also as requested by Arun, this patch introduces a new TPG attribute named 'login_keys_workaround' that controls the use of both the FirstBurstLength workaround, as well as the two other existing workarounds for gPXE iSCSI boot client. By default, the workaround is enabled with login_keys_workaround=1, since Mellanox FlexBoot requires it, and Arun has verified the Qlogic MSFT initiator already proposes FirstBurstLength, so it's uneffected by this re-adding this part of the original work-around. Reported-by:Robert LeBlanc <robert@leblancnet.us> Cc: Robert LeBlanc <robert@leblancnet.us> Reviewed-by:
Arun Easi <arun.easi@cavium.com> Cc: <stable@vger.kernel.org> # 3.1+ Signed-off-by:
Nicholas Bellinger <nab@linux-iscsi.org>
Showing
- drivers/target/iscsi/iscsi_target_configfs.c 2 additions, 0 deletionsdrivers/target/iscsi/iscsi_target_configfs.c
- drivers/target/iscsi/iscsi_target_nego.c 4 additions, 2 deletionsdrivers/target/iscsi/iscsi_target_nego.c
- drivers/target/iscsi/iscsi_target_parameters.c 28 additions, 13 deletionsdrivers/target/iscsi/iscsi_target_parameters.c
- drivers/target/iscsi/iscsi_target_parameters.h 1 addition, 1 deletiondrivers/target/iscsi/iscsi_target_parameters.h
- drivers/target/iscsi/iscsi_target_tpg.c 19 additions, 0 deletionsdrivers/target/iscsi/iscsi_target_tpg.c
- drivers/target/iscsi/iscsi_target_tpg.h 1 addition, 0 deletionsdrivers/target/iscsi/iscsi_target_tpg.h
- include/target/iscsi/iscsi_target_core.h 9 additions, 0 deletionsinclude/target/iscsi/iscsi_target_core.h
Loading
Please register or sign in to comment