Skip to content
Snippets Groups Projects
Commit 37b617f9 authored by Christian Engelmayer's avatar Christian Engelmayer Committed by Tomi Valkeinen
Browse files

video: Fix possible leak in of_get_videomode()


In case videomode_from_timings() fails in function of_get_videomode(), the
allocated display timing data is not freed in the exit path. Make sure that
display_timings_release() is called in any case. Detected by Coverity CID
1309681.

Signed-off-by: default avatarChristian Engelmayer <cengelma@gmx.at>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 9e6e35ed
No related branches found
No related tags found
No related merge requests found
...@@ -44,11 +44,9 @@ int of_get_videomode(struct device_node *np, struct videomode *vm, ...@@ -44,11 +44,9 @@ int of_get_videomode(struct device_node *np, struct videomode *vm,
index = disp->native_mode; index = disp->native_mode;
ret = videomode_from_timings(disp, vm, index); ret = videomode_from_timings(disp, vm, index);
if (ret)
return ret;
display_timings_release(disp); display_timings_release(disp);
return 0; return ret;
} }
EXPORT_SYMBOL_GPL(of_get_videomode); EXPORT_SYMBOL_GPL(of_get_videomode);
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment