-
- Downloads
alpha: fix RTC on marvel
Unlike other alphas, marvel doesn't have real PC-style CMOS clock hardware - RTC accesses are emulated via PAL calls. Unfortunately, for unknown reason these calls work only on CPU #0. So current implementation for arbitrary CPU makes CMOS_READ/WRITE to be executed on CPU #0 via IPI. However, for obvious reason this doesn't work with standard get/set_rtc_time() functions, where a bunch of CMOS accesses is done with disabled interrupts. Solved by making the IPI calls for entire get/set_rtc_time() functions, not for individual CMOS accesses. Which is also a lot more effective performance-wise. The patch is largely based on the code from Jay Estabrook. My changes: - tweak asm-generic/rtc.h by adding a couple of #defines to avoid a massive code duplication in arch/alpha/include/asm/rtc.h; - sys_marvel.c: fix get/set_rtc_time() return values (Jay's FIXMEs). NOTE: this fixes *only* LIB_RTC drivers. Legacy (CONFIG_RTC) driver wont't work on marvel. Actually I think that we should just disable CONFIG_RTC on alpha (maybe in 2.6.30?), like most other arches - AFAIK, all modern distributions use LIB_RTC anyway. Signed-off-by:Ivan Kokshaysky <ink@jurassic.park.msu.ru> Cc: Richard Henderson <rth@twiddle.net> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
Showing
- arch/alpha/include/asm/machvec.h 4 additions, 0 deletionsarch/alpha/include/asm/machvec.h
- arch/alpha/include/asm/rtc.h 9 additions, 3 deletionsarch/alpha/include/asm/rtc.h
- arch/alpha/kernel/core_marvel.c 1 addition, 9 deletionsarch/alpha/kernel/core_marvel.c
- arch/alpha/kernel/machvec_impl.h 4 additions, 1 deletionarch/alpha/kernel/machvec_impl.h
- arch/alpha/kernel/proto.h 2 additions, 0 deletionsarch/alpha/kernel/proto.h
- arch/alpha/kernel/sys_jensen.c 2 additions, 0 deletionsarch/alpha/kernel/sys_jensen.c
- arch/alpha/kernel/sys_marvel.c 55 additions, 1 deletionarch/alpha/kernel/sys_marvel.c
- arch/alpha/kernel/time.c 10 additions, 0 deletionsarch/alpha/kernel/time.c
- include/asm-generic/rtc.h 11 additions, 3 deletionsinclude/asm-generic/rtc.h
Loading
Please register or sign in to comment