Skip to content
Snippets Groups Projects
Commit 7df5a5f6 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: pcm: Avoid confusing loop in snd_pcm_unlink()


The snd_pcm_group_for_each_entry() loop found in snd_pcm_unlink() is
only for taking the first list entry.  Use list_first_entry() to make
clearer.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent a41c4cb9
No related branches found
No related tags found
No related merge requests found
...@@ -2023,7 +2023,6 @@ static void relink_to_local(struct snd_pcm_substream *substream) ...@@ -2023,7 +2023,6 @@ static void relink_to_local(struct snd_pcm_substream *substream)
static int snd_pcm_unlink(struct snd_pcm_substream *substream) static int snd_pcm_unlink(struct snd_pcm_substream *substream)
{ {
struct snd_pcm_substream *s;
struct snd_pcm_group *group; struct snd_pcm_group *group;
int res = 0; int res = 0;
...@@ -2040,10 +2039,9 @@ static int snd_pcm_unlink(struct snd_pcm_substream *substream) ...@@ -2040,10 +2039,9 @@ static int snd_pcm_unlink(struct snd_pcm_substream *substream)
/* detach the last stream, too */ /* detach the last stream, too */
if (list_is_singular(&group->substreams)) { if (list_is_singular(&group->substreams)) {
snd_pcm_group_for_each_entry(s, substream) { relink_to_local(list_first_entry(&group->substreams,
relink_to_local(s); struct snd_pcm_substream,
break; link_list));
}
kfree(group); kfree(group);
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment