Skip to content
Snippets Groups Projects
Commit 884d25cc authored by James Bottomley's avatar James Bottomley Committed by James Bottomley
Browse files

[SCSI] Fix refcount breakage with 'echo "1" > scan' when target already present


Spotted by: Dan Aloni <da-xx@monatomic.org>

The problem is there's inconsistent locking semantic usage of
scsi_alloc_target().  Two callers assume the target comes back with
reference unincremented and the third assumes its incremented.  Fix by
always making the reference incremented on return.  Also fix path in
target alloc that could consistently increment the parent lock.
Finally document scsi_alloc_target() so its callers know what the
expectations are.

Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 26dacd0c
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment