Skip to content
Snippets Groups Projects
Commit c176d1c7 authored by Wei Yongjun's avatar Wei Yongjun Committed by Bjorn Helgaas
Browse files

PCI: rcar: Fix rcar_pci_probe() return value check


In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL.  The NULL test in the return value check should
be replaced with IS_ERR().

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarJingoo Han <jg1.han@samsung.com>
parent 6ce4eac1
No related branches found
No related tags found
No related merge requests found
...@@ -276,8 +276,8 @@ static int __init rcar_pci_probe(struct platform_device *pdev) ...@@ -276,8 +276,8 @@ static int __init rcar_pci_probe(struct platform_device *pdev)
cfg_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); cfg_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
reg = devm_ioremap_resource(&pdev->dev, cfg_res); reg = devm_ioremap_resource(&pdev->dev, cfg_res);
if (!reg) if (IS_ERR(reg))
return -ENODEV; return PTR_ERR(reg);
mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 1); mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
if (!mem_res || !mem_res->start) if (!mem_res || !mem_res->start)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment