Skip to content
Snippets Groups Projects
Commit d5580232 authored by Sasha Levin's avatar Sasha Levin Committed by Benjamin LaHaise
Browse files

aio: prevent double free in ioctx_alloc


ioctx_alloc() calls aio_setup_ring() to allocate a ring. If aio_setup_ring()
fails to do so it would call aio_free_ring() before returning, but
ioctx_alloc() would call aio_free_ring() again causing a double free of
the ring.

This is easily reproducible from userspace.

Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
Signed-off-by: default avatarBenjamin LaHaise <bcrl@kvack.org>
parent 13fd8a5d
No related branches found
No related tags found
No related merge requests found
...@@ -610,7 +610,6 @@ static struct kioctx *ioctx_alloc(unsigned nr_events) ...@@ -610,7 +610,6 @@ static struct kioctx *ioctx_alloc(unsigned nr_events)
err_cleanup: err_cleanup:
aio_nr_sub(ctx->max_reqs); aio_nr_sub(ctx->max_reqs);
err: err:
aio_free_ring(ctx);
free_percpu(ctx->cpu); free_percpu(ctx->cpu);
free_percpu(ctx->reqs.pcpu_count); free_percpu(ctx->reqs.pcpu_count);
free_percpu(ctx->users.pcpu_count); free_percpu(ctx->users.pcpu_count);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment