Skip to content
Snippets Groups Projects
Select Git revision
  • a068b94d74ddb7776ca707b6d39d1ac0d2d057e6
  • vme-testing default
  • ci-test
  • master
  • remoteproc
  • am625-sk-ov5640
  • pcal6534-upstreaming
  • lps22df-upstreaming
  • msc-upstreaming
  • imx8mp
  • iio/noa1305
  • vme-next
  • vme-next-4.14-rc4
  • v4.14-rc4
  • v4.14-rc3
  • v4.14-rc2
  • v4.14-rc1
  • v4.13
  • vme-next-4.13-rc7
  • v4.13-rc7
  • v4.13-rc6
  • v4.13-rc5
  • v4.13-rc4
  • v4.13-rc3
  • v4.13-rc2
  • v4.13-rc1
  • v4.12
  • v4.12-rc7
  • v4.12-rc6
  • v4.12-rc5
  • v4.12-rc4
  • v4.12-rc3
32 results

linux

  • Clone with SSH
  • Clone with HTTPS
  • user avatar
    Eric Biggers authored and Herbert Xu committed
    Building the kernel with CONFIG_THUMB2_KERNEL=y and
    CONFIG_CRYPTO_SPECK_NEON set fails with the following errors:
    
        arch/arm/crypto/speck-neon-core.S: Assembler messages:
    
        arch/arm/crypto/speck-neon-core.S:419: Error: r13 not allowed here -- `bic sp,#0xf'
        arch/arm/crypto/speck-neon-core.S:423: Error: r13 not allowed here -- `bic sp,#0xf'
        arch/arm/crypto/speck-neon-core.S:427: Error: r13 not allowed here -- `bic sp,#0xf'
        arch/arm/crypto/speck-neon-core.S:431: Error: r13 not allowed here -- `bic sp,#0xf'
    
    The problem is that the 'bic' instruction can't operate on the 'sp'
    register in Thumb2 mode.  Fix it by using a temporary register.  This
    isn't in the main loop, so the performance difference is negligible.
    This also matches what aes-neonbs-core.S does.
    
    Reported-by: default avatarStefan Agner <stefan@agner.ch>
    Fixes: ede96221 ("crypto: arm/speck - add NEON-accelerated implementation of Speck-XTS")
    Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
    Acked-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
    Reviewed-by: default avatarStefan Agner <stefan@agner.ch>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    a068b94d
    History
    Name Last commit Last update