Skip to content
Snippets Groups Projects
  • cpu@chromium.org's avatar
    4512f3ac
    Rewrite of chrome.exe startup code · 4512f3ac
    cpu@chromium.org authored
    A lot of cruft and repeated code has deposited over the years on chrome's initialization code.
    This CL makes it all much more clear and straightforward. There is no fundamental change of
    behavior except the order of certain things is different but it should not alter the observed
    operation.
    
    - chrome's and chromium load is fundamentally the same but most of the code was repeated
    - chrome's way to load the dll was incorrect: using a relative path with LOAD_WITH_ALTERED_SEARCH_PATH
    - Use of SearchPath() was dangerous and not needed
    - removed google_update_client.cc and .h
    - removed bunch of #ifdefs
    
    TEST=all convered by UI tests already except [1]
    BUG=none
    
    [1] The only thing I don't see convered by test is the restart dialog ('woa! chrome crashed').
    
    
    Review URL: http://codereview.chromium.org/345036
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30934 0039d316-1c4b-4281-b951-d872f2087c98
    4512f3ac
    History
    Rewrite of chrome.exe startup code
    cpu@chromium.org authored
    A lot of cruft and repeated code has deposited over the years on chrome's initialization code.
    This CL makes it all much more clear and straightforward. There is no fundamental change of
    behavior except the order of certain things is different but it should not alter the observed
    operation.
    
    - chrome's and chromium load is fundamentally the same but most of the code was repeated
    - chrome's way to load the dll was incorrect: using a relative path with LOAD_WITH_ALTERED_SEARCH_PATH
    - Use of SearchPath() was dangerous and not needed
    - removed google_update_client.cc and .h
    - removed bunch of #ifdefs
    
    TEST=all convered by UI tests already except [1]
    BUG=none
    
    [1] The only thing I don't see convered by test is the restart dialog ('woa! chrome crashed').
    
    
    Review URL: http://codereview.chromium.org/345036
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30934 0039d316-1c4b-4281-b951-d872f2087c98