Fixes bug in instant that resulted in flickery fade. The problem would
happen if instant wouldn't load the current url and you continued typing. For example, if the search engine doesn't support the instant API on each key press you would see the page fade out, then snap in. The fix is to make sure instant stays active until destroyed. That way if the preview is no longer valid, but instant is still active the page can remain faded out. This also adds a couple more tests for better coverage. BUG=66720 66539 TEST=see bug Review URL: http://codereview.chromium.org/5701008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69201 0039d316-1c4b-4281-b951-d872f2087c98
Showing
- chrome/browser/gtk/browser_window_gtk.cc 3 additions, 1 deletionchrome/browser/gtk/browser_window_gtk.cc
- chrome/browser/gtk/browser_window_gtk.h 1 addition, 1 deletionchrome/browser/gtk/browser_window_gtk.h
- chrome/browser/instant/instant_browsertest.cc 155 additions, 13 deletionschrome/browser/instant/instant_browsertest.cc
- chrome/browser/instant/instant_controller.cc 51 additions, 21 deletionschrome/browser/instant/instant_controller.cc
- chrome/browser/instant/instant_controller.h 20 additions, 3 deletionschrome/browser/instant/instant_controller.h
- chrome/browser/instant/instant_delegate.h 3 additions, 1 deletionchrome/browser/instant/instant_delegate.h
- chrome/browser/ui/browser.cc 1 addition, 1 deletionchrome/browser/ui/browser.cc
- chrome/browser/ui/browser_window.h 2 additions, 1 deletionchrome/browser/ui/browser_window.h
- chrome/browser/ui/cocoa/browser_window_cocoa.h 1 addition, 1 deletionchrome/browser/ui/cocoa/browser_window_cocoa.h
- chrome/browser/ui/cocoa/browser_window_cocoa.mm 3 additions, 1 deletionchrome/browser/ui/cocoa/browser_window_cocoa.mm
- chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm 5 additions, 6 deletions...me/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
- chrome/browser/ui/views/frame/browser_view.cc 6 additions, 4 deletionschrome/browser/ui/views/frame/browser_view.cc
- chrome/browser/ui/views/frame/browser_view.h 1 addition, 1 deletionchrome/browser/ui/views/frame/browser_view.h
- chrome/browser/ui/views/frame/contents_container.cc 61 additions, 15 deletionschrome/browser/ui/views/frame/contents_container.cc
- chrome/browser/ui/views/frame/contents_container.h 14 additions, 0 deletionschrome/browser/ui/views/frame/contents_container.h
- chrome/test/data/instant/403.html 2 additions, 0 deletionschrome/test/data/instant/403.html
- chrome/test/data/instant/403.html.mock-http-headers 1 addition, 0 deletionschrome/test/data/instant/403.html.mock-http-headers
- chrome/test/test_browser_window.h 1 addition, 1 deletionchrome/test/test_browser_window.h
Loading
Please register or sign in to comment