CL is the same as http://codereview.chromium.org/173487, but had to be moved...
CL is the same as http://codereview.chromium.org/173487, but had to be moved to new CL number because I switched machines. Implemented the rest of loading/parsing logic for extension i18n: 1. Loading message catalogs for default and application locale. 2. Parsing JSON and replacing placeholders with actual content within a message. 3. Creating unified dictionary (union of default and application dictionaries, where application dict. has priority for common messages). New class ExtensionMessageBundle holds new dictionary, and parses data. It's injected into Extension. ExtensionMessageHandler::ReplaceVariablesInString can replace both $placeholders$ and __MSG_messages__ in given string (HTML, manifest, actual message string...). Implemented actual manifest name/description replacement too, as an example. Extension is now pretty agnostic about localization, and this makes it easier to use message bundles with things that are not extensions... BUG=12131 Review URL: http://codereview.chromium.org/202063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26609 0039d316-1c4b-4281-b951-d872f2087c98
Showing
- chrome/browser/extensions/extension_file_util.cc 46 additions, 19 deletionschrome/browser/extensions/extension_file_util.cc
- chrome/browser/extensions/extension_file_util.h 14 additions, 2 deletionschrome/browser/extensions/extension_file_util.h
- chrome/browser/extensions/extension_file_util_unittest.cc 21 additions, 51 deletionschrome/browser/extensions/extension_file_util_unittest.cc
- chrome/browser/extensions/extension_l10n_util.cc 69 additions, 15 deletionschrome/browser/extensions/extension_l10n_util.cc
- chrome/browser/extensions/extension_l10n_util.h 19 additions, 6 deletionschrome/browser/extensions/extension_l10n_util.h
- chrome/browser/extensions/extension_l10n_util_unittest.cc 75 additions, 89 deletionschrome/browser/extensions/extension_l10n_util_unittest.cc
- chrome/browser/extensions/extension_message_bundle.cc 256 additions, 0 deletionschrome/browser/extensions/extension_message_bundle.cc
- chrome/browser/extensions/extension_message_bundle.h 110 additions, 0 deletionschrome/browser/extensions/extension_message_bundle.h
- chrome/browser/extensions/extension_message_bundle_unittest.cc 288 additions, 0 deletions...e/browser/extensions/extension_message_bundle_unittest.cc
- chrome/browser/extensions/extension_ui_unittest.cc 0 additions, 3 deletionschrome/browser/extensions/extension_ui_unittest.cc
- chrome/chrome.gyp 3 additions, 0 deletionschrome/chrome.gyp
- chrome/common/extensions/extension.cc 12 additions, 14 deletionschrome/common/extensions/extension.cc
- chrome/common/extensions/extension.h 9 additions, 18 deletionschrome/common/extensions/extension.h
- chrome/common/extensions/extension_unittest.cc 0 additions, 6 deletionschrome/common/extensions/extension_unittest.cc
- chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales/en_US/messages.json 6 additions, 3 deletions...nphdnhnkndlbkcpglgmj/1.0.0.0/_locales/en_US/messages.json
- chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales/sr/messages.json 6 additions, 3 deletions...fkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales/sr/messages.json
Loading
Please register or sign in to comment