This adds some plumbing for propagating the status and error code of a...
This adds some plumbing for propagating the status and error code of a renderer process that went away so that we can tell at the UI level what happened to the tab: did it crash, or was it killed by the OOM killer (or some other reason). This is in preparation for implementing a new UI for when a process is killed by the OOM on ChromeOS which handles it differently from a crash. Most of the changes are modifications of the argument list to include a status and error code for the exited process, but in addition the following was done: - Changed the name of DidProcessCrash to GetTerminationStatus. - Added TerminationStatus enum in process_util.h, so it can be used as the status returned by GetTerminationStatus. - Improved process_util_unittest to actually test for crashing and terminated processes on all platforms. - Added a new notification for renderers that were killed. - Added error code information to crash notification. - Added status and error code information to renderer IPC message for RenderViewGone. - Added a UMA histogram count for number of renderer kills. BUG=http://crosbug.com/8505 TEST=ran new unit test. Test passes on try servers. Review URL: http://codereview.chromium.org/5172009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69082 0039d316-1c4b-4281-b951-d872f2087c98
Showing
- base/process_util.h 19 additions, 12 deletionsbase/process_util.h
- base/process_util_posix.cc 24 additions, 17 deletionsbase/process_util_posix.cc
- base/process_util_unittest.cc 155 additions, 17 deletionsbase/process_util_unittest.cc
- base/process_util_win.cc 54 additions, 32 deletionsbase/process_util_win.cc
- chrome/browser/browser_child_process_host.cc 24 additions, 8 deletionschrome/browser/browser_child_process_host.cc
- chrome/browser/browser_child_process_host.h 17 additions, 5 deletionschrome/browser/browser_child_process_host.h
- chrome/browser/child_process_launcher.cc 12 additions, 11 deletionschrome/browser/child_process_launcher.cc
- chrome/browser/child_process_launcher.h 5 additions, 2 deletionschrome/browser/child_process_launcher.h
- chrome/browser/child_process_security_policy_browsertest.cc 2 additions, 1 deletionchrome/browser/child_process_security_policy_browsertest.cc
- chrome/browser/extensions/extension_crash_recovery_browsertest.cc 2 additions, 2 deletions...rowser/extensions/extension_crash_recovery_browsertest.cc
- chrome/browser/extensions/extension_host.cc 3 additions, 1 deletionchrome/browser/extensions/extension_host.cc
- chrome/browser/extensions/extension_host.h 3 additions, 1 deletionchrome/browser/extensions/extension_host.h
- chrome/browser/extensions/sandboxed_extension_unpacker.cc 1 addition, 1 deletionchrome/browser/extensions/sandboxed_extension_unpacker.cc
- chrome/browser/extensions/sandboxed_extension_unpacker.h 1 addition, 1 deletionchrome/browser/extensions/sandboxed_extension_unpacker.h
- chrome/browser/gpu_process_host.cc 2 additions, 2 deletionschrome/browser/gpu_process_host.cc
- chrome/browser/gpu_process_host.h 1 addition, 1 deletionchrome/browser/gpu_process_host.h
- chrome/browser/importer/importer.cc 1 addition, 1 deletionchrome/browser/importer/importer.cc
- chrome/browser/importer/importer.h 1 addition, 1 deletionchrome/browser/importer/importer.h
- chrome/browser/in_process_webkit/indexed_db_key_utility_client.cc 1 addition, 1 deletion...rowser/in_process_webkit/indexed_db_key_utility_client.cc
- chrome/browser/in_process_webkit/indexed_db_key_utility_client.h 1 addition, 1 deletion...browser/in_process_webkit/indexed_db_key_utility_client.h
Loading
Please register or sign in to comment