Mac: Let out-of-process tests run in bundled mode for their whole lifetime.
Since out-of-process tests override the EXE path to look like the bundled app, it makes sense to override AmIBundled() as well. This is important because the renderer process started from browser_tests runs as bundled, and if browser and renderer process don't agree on bundled-ness, the "load plugin" requests for internal plugins from the renderer have the wrong plugin path, causing the plugin load to fail. Also add a DCHECK that makes sure that AmIBundled() doesn't flip-flop. This makes PDFBrowserTest work on mac, so enable it. It looks like even unit_tests uses the out-of-process test runner, so this change is a bit hairy :-/ BUG=61258,63183 TEST=all existing tests still pass, PDFBrowserTest.* passes. Review URL: http://codereview.chromium.org/4947002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66156 0039d316-1c4b-4281-b951-d872f2087c98
Showing
- base/base_paths_mac.mm 2 additions, 1 deletionbase/base_paths_mac.mm
- base/mac_util.h 1 addition, 0 deletionsbase/mac_util.h
- base/mac_util.mm 24 additions, 1 deletionbase/mac_util.mm
- chrome/common/pepper_plugin_registry.cc 1 addition, 1 deletionchrome/common/pepper_plugin_registry.cc
- chrome/test/in_process_browser_test.cc 30 additions, 24 deletionschrome/test/in_process_browser_test.cc
- chrome/test/in_process_browser_test.h 2 additions, 2 deletionschrome/test/in_process_browser_test.h
- chrome/test/plugin/pdf_browsertest.cc 24 additions, 6 deletionschrome/test/plugin/pdf_browsertest.cc
Loading
Please register or sign in to comment