Skip to content
Snippets Groups Projects
Commit 7fac888e authored by thakis@chromium.org's avatar thakis@chromium.org
Browse files

Mac: Let out-of-process tests run in bundled mode for their whole lifetime.

Since out-of-process tests override the EXE path to look like the bundled app, it makes sense to override AmIBundled() as well.

This is important because the renderer process started from browser_tests runs as bundled, and if browser and renderer process don't agree on bundled-ness, the "load plugin" requests for internal plugins from the renderer have the wrong plugin path, causing the plugin load to fail.

Also add a DCHECK that makes sure that AmIBundled() doesn't flip-flop.

This makes PDFBrowserTest work on mac, so enable it.

It looks like even unit_tests uses the out-of-process test runner, so this change is a bit hairy :-/

BUG=61258,63183
TEST=all existing tests still pass, PDFBrowserTest.* passes.

Review URL: http://codereview.chromium.org/4947002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66156 0039d316-1c4b-4281-b951-d872f2087c98
parent 490348b9
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment