From e876f3c363a2a0af6c755795b958a60a0292f24c Mon Sep 17 00:00:00 2001 From: "tyoshino@google.com" <tyoshino@google.com@0039d316-1c4b-4281-b951-d872f2087c98> Date: Fri, 25 Sep 2009 05:04:57 +0000 Subject: [PATCH] Use URL constants instead of writing string literals in test using history page address. BUG=none TEST=none Review URL: http://codereview.chromium.org/200142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27172 0039d316-1c4b-4281-b951-d872f2087c98 --- .../autocomplete/autocomplete_edit_view_browsertest.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc b/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc index 691728f99ca17..aec506216c1e1 100644 --- a/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc +++ b/chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc @@ -29,6 +29,7 @@ #include "chrome/browser/tab_contents/tab_contents.h" #include "chrome/common/chrome_paths.h" #include "chrome/common/notification_service.h" +#include "chrome/common/url_constants.h" #include "chrome/test/in_process_browser_test.h" #include "chrome/test/ui_test_utils.h" #include "net/base/mock_host_resolver.h" @@ -363,7 +364,7 @@ IN_PROC_BROWSER_TEST_F(AutocompleteEditViewTest, BackspaceInKeywordMode) { } IN_PROC_BROWSER_TEST_F(AutocompleteEditViewTest, Escape) { - ui_test_utils::NavigateToURL(browser(), GURL("chrome://history/")); + ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIHistoryURL)); browser()->FocusLocationBar(); AutocompleteEditView* edit_view = NULL; @@ -411,7 +412,7 @@ IN_PROC_BROWSER_TEST_F(AutocompleteEditViewTest, AltEnter) { AutocompleteEditView* edit_view = NULL; ASSERT_NO_FATAL_FAILURE(GetAutocompleteEditView(&edit_view)); - edit_view->SetUserText(L"chrome://history/"); + edit_view->SetUserText(ASCIIToWide(chrome::kChromeUIHistoryURL)); int tab_count = browser()->tab_count(); // alt-Enter opens a new tab. ASSERT_NO_FATAL_FAILURE(SendKey(base::VKEY_RETURN, false, false, true)); -- GitLab