- Sep 25, 2009
-
-
mattm@chromium.org authored
Removing valgrind suppressions that have not triggered in the last 100 runs. (Doesn't cover suppressions_mac.txt) Some suppressions didn't trigger because the test was disabled. It is assumed that before re-enabling such a test someone would fix it and check that it doesn't still need any suppressions: BUG=6522 BUG=11838 Not reproducible, bug is already closed: BUG=10750 BUG=11117 BUG=12539,12549,12661 Not reproducible (or not enough info to try): BUG=4609 BUG=16103 BUG=16129 (probably fixed by r20100) BUG=16578 BUG=16584 BUG=16586 BUG=16625 BUG=16908 BUG=18654 BUG=19385 BUG=19490 Review URL: http://codereview.chromium.org/219021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27168 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
TBR=jungshik Review URL: http://codereview.chromium.org/242001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27167 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Also make tab dragging slightly more robust. I tried really hard to avoid hackiness, but after many hours of wrestling with gtk and X, this is the best I could do. The main point of contention is that GTK (and our tab dragging code in particular) seems to be able to get X into a state where gdk_display_warp_pointer() doesn't send back any events (although it does move the X pointer). I tried to fix our code directly, but decided it was GTK that was broken. So I faked some mouse motion events to prod the tab dragging into working. This approach does not appear to be flaky, and is actually closer to the event stream that occurs when a user drags a tab than the obvious approach would be. (The tests themselves are somewhat flaky, but only due to WaitForURLDisplayedForTab() flakiness, which is a separate issue I'll look at later. The tests aren't on any buildbot for now so I'd like to leave them enabled.) BUG=22182 TEST=--gtest_filter=AutomatedUITest.Drag* Review URL: http://codereview.chromium.org/218017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27166 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=22872 Review URL: http://codereview.chromium.org/218037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27165 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27164 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
the NSS function SGN_Update. R=rafaelw BUG=20669 TEST=none Review URL: http://codereview.chromium.org/218035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27163 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
Actually on Windows VirtualAlloc'ated address might have bigger alignment than reported by SYSTEM_INFO.dwPageSize, see SYSTEM_INFO.dwAllocationGranularity. As coalescing of spans in tcmalloc requires that those spans are physically adjacent, using smaller alignment inhibited coalescing. Additional benefit is we now require ways less memory at least in some case. Also adds assert()s for alignment values that would lead to pathological virtual address space waste. No current callers pass in alignment values other than kPageSize and it's unlikely anyone will. Original patch and discussion was at http://codereview.chromium.org/235003 Patch by: antonm@chromium.org BUG=22701 TEST=Manually checked test page that did 10m XHR. Memory use goes from >2GB and a crash to 102MB. Membuster shows the change is roughly within noise and possibly a very slight regression ( <<5% ). Review URL: http://codereview.chromium.org/222028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27162 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
It was mostly unneeded, but I had to excise the last bits of RLZ and move some NOTIMPLEMENTED bits to where they belong. Review URL: http://codereview.chromium.org/219042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27161 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/196053jshin@chromium.org authored
BUG=none TEST=UI test and valgrind test pass TBR=markus Review URL: http://codereview.chromium.org/222031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27160 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@google.com authored
Review URL: http://codereview.chromium.org/231027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27159 0039d316-1c4b-4281-b951-d872f2087c98
-
dimich@google.com authored
More fixes for WorkerFastLayoutTests: enable them on Mac and Win, reintroduce Linux guard that was removed by http://codereview.chromium.org/220034, since the test that fails on all platforms was disabled earlier: http://codereview.chromium.org/219033 BUG=none TEST=none TBR=jshin Review URL: http://codereview.chromium.org/224022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27158 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/235012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27157 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
TBR=jrg Review URL: http://codereview.chromium.org/208004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27156 0039d316-1c4b-4281-b951-d872f2087c98
-
jshin@chromium.org authored
Add the stack signature of a small memory leak found in SessionHistoryTest.HistorySearchXSS to the valgrind suppression list. BUG=22984 TEST=Valgrind bot does not report this leak any more when running SessionHistoryTest.HistorySearchXSS TBR=dank Review URL: http://codereview.chromium.org/223030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27155 0039d316-1c4b-4281-b951-d872f2087c98
-
laforge@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27154 0039d316-1c4b-4281-b951-d872f2087c98
-
laforge@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27153 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
not being ref counted. It's owned by the profile and it doesn't need to be ref counted. Review URL: http://codereview.chromium.org/223027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27152 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Clean up a few bits of files that I'm about to modify. The only visible change is the removal of some extra spacing Ben erroneously added to the link infobar a while back (clients already do their own spacing as needed, so this just added extra whitespace in mid-sentence). BUG=none TEST=none Review URL: http://codereview.chromium.org/223029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27151 0039d316-1c4b-4281-b951-d872f2087c98
-
sidchat@chromium.org authored
Updated comment in tab_switching.cc to replect that Tab-switching test in buildbot was outputting 0 because it was missing command line flag -log-level=0. log-level decides the amount of output in the log file, and histograms come under log-level 0. The default was 1, which meant that histograms were not logged - hence the results always showed 0. BUG=www.crbug.com/22965 TEST=none Review URL: http://codereview.chromium.org/239006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27150 0039d316-1c4b-4281-b951-d872f2087c98
-
- Sep 24, 2009
-
-
laforge@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27149 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TEST=Covered by browser_tests. BUG=19876 Review URL: http://codereview.chromium.org/218038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27147 0039d316-1c4b-4281-b951-d872f2087c98
-
markus@chromium.org authored
we have to be careful to consistently round in the same direction. Timeout checks usually check if Now() is less or equal to a deadline in order to determine if a timeout has occurred. This correctly handles the case where actual sleep times are equal or longer than requested sleep times. But if we round down when setting the sleep delay, this can result in unnecessary and expensive looping. Make sure, we always round up when converting to a format with less precision. BUG=none TEST=none Review URL: http://codereview.chromium.org/196053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27146 0039d316-1c4b-4281-b951-d872f2087c98
-
mhm@chromium.org authored
Fix hottracking on button views.The hottracking on the toolbar was broken, the expected behavoir is when focus is set to the toolbar (by hitting SHIFT+ALT+T) and toolbar buttons are traversed by right/left arrow keys, a bevel should appear on the button (HOT Image). This patch fixes the initial hottracking issue where the first item is not hottracked. BUG=10942 TEST=ALT+SHIFT+T and traverse with arrow keys, observe hot tracking. Review URL: http://codereview.chromium.org/194037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27145 0039d316-1c4b-4281-b951-d872f2087c98
-
jorlow@chromium.org authored
TBR=nsylvain TEST=Unit tests now work. BUG=22971 Review URL: http://codereview.chromium.org/231024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27144 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
blocking the UI" BUG=14040 TBR=erikkay git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27143 0039d316-1c4b-4281-b951-d872f2087c98
-
jshin@chromium.org authored
BUG=10476 TEST=NONE TBR=dglazkov Review URL: http://codereview.chromium.org/239005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27141 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
CID=1640 BUG=none TEST=none Review URL: http://codereview.chromium.org/225020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27140 0039d316-1c4b-4281-b951-d872f2087c98
-
jorlow@chromium.org authored
Match the new interfaces used for StorageNamespace in WebKit. TBR=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/219038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27139 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Simplify life for people trying to pick a "readable" foreground color by not requiring them to provide two choices. This also speeds the call up a tiny bit by not calculating the background luminance twice. BUG=none TEST=none Review URL: http://codereview.chromium.org/220029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27138 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
BUG=14040 TEST=Install a bunch of extensions with toolstrips, then restart Chrome. The UI should be responsive while the toolstrips are loading. Review URL: http://codereview.chromium.org/220028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27137 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
CID=1608 BUG=none TEST=none Review URL: http://codereview.chromium.org/222024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27136 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
CID=1602 BUG=none TEST=none Review URL: http://codereview.chromium.org/223026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27135 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
CID=1484 BUG=none TEST=none Review URL: http://codereview.chromium.org/222026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27134 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=Run a debug copy of Chromium over VNC, should not hit the DCHECK. Review URL: http://codereview.chromium.org/218024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27133 0039d316-1c4b-4281-b951-d872f2087c98
-
victorw@chromium.org authored
instead of vista bot which is not stable now. TBR=dpranke TEST=none BUG=none Review URL: http://codereview.chromium.org/224013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27132 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Add about: and chrome:* to history. Patch by Pierre-Antoine LaFayette (see http://codereview.chromium.org/193071 ), r=me,brettw. BUG=2958 TEST=Visit "about:", then hit ctrl-h and make sure it's in your history. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27131 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
This fixes leaks caused by not calling gtk_widget_destroy on dialog windows when we exit. While I'm here, fix a GList leak on Linux toolkit views. Review URL: http://codereview.chromium.org/223015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27130 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
This way we get a native VMS listing and not a UNIX emulation mode, which is slightly different than native UNIX and confuses the parser. TEST=Covered by net_unittests. BUG=22193 Review URL: http://codereview.chromium.org/215058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27129 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
The previous version of the code assumed that \r\n (CRLF) will always be used. The FTP spec is extremely imprecise about the LISTing format. TEST=See bug. BUG=22879 Review URL: http://codereview.chromium.org/238001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27128 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitrao@chromium.org authored
BUG=http://crbug.com/22882 TEST=Type something into the omnibox. Option-return should open it in a new foreground tab. TEST=After using Option-return to open something in a new foreground tab, switch back to the original tab and verify that the url in the omnibox has reverted to the original page's url. TEST=Option-leftclick on a link in a webpage should still prompt you to "save as." Review URL: http://codereview.chromium.org/218032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27127 0039d316-1c4b-4281-b951-d872f2087c98
-