BUG=17093
TEST=in GNOME, let Firefox set itself as the default after Chrome has set itself; Chrome should then detect that it is no longer the default

Review URL: http://codereview.chromium.org/155889

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21260 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155799

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21259 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/159057
Patch from Thiago Farina <thiago.farina@gmail.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21258 0039d316-1c4b-4281-b951-d872f2087c98

Baseline must have changed with last merge.

BUG=17326
TBR=paul

Review URL: http://codereview.chromium.org/155903

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21257 0039d316-1c4b-4281-b951-d872f2087c98

The tab text was previously one pixel too high. With this patch it matches Windows.

I think before Evan's recent font size patch, this issue was hidden by favorable rounding.

Review URL: http://codereview.chromium.org/159169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21256 0039d316-1c4b-4281-b951-d872f2087c98

BUG=17393
TEST=drag nntp thumbnail to bookmark bar

Review URL: http://codereview.chromium.org/155900

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21255 0039d316-1c4b-4281-b951-d872f2087c98

BUG=14518
TEST=see bug

Review URL: http://codereview.chromium.org/155902

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21254 0039d316-1c4b-4281-b951-d872f2087c98

Only the first issue is remotely interesting.

* Possibility (low) of using NULL SinkStream* courgette tool 'gen1a' command.

* Added initializers for all class members to several constructors.

* return 0 at end of from wmain.

BUG=none
TEST=existing

Review URL: http://codereview.chromium.org/155820

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21253 0039d316-1c4b-4281-b951-d872f2087c98

This adds project dependencies to test_shell so that all (and only?)
the targets needed for the layout_tests to run cleanly are built. On most
platforms this is test_shell, npapi_test_plugin, and test_worker, and on
the Mac this adds the layout_test_helper binary as well

also, this moves image_diff from chrome/tools/test to tools/

R=mmentovai@google.com, darin@google.com
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/149714

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21252 0039d316-1c4b-4281-b951-d872f2087c98

This lets Linux not bother to initialize NSS in the same way as the rest, but instead use the NSS symbols linked into the library, thereby preventing the NSS_Shutdown related bugs.
BUG=http://crbug.com/13929
TEST=Case 1: Start chrome.  Use firefox import utility.  Browse to some https site.  Shouldn't crash.  Case 2: Start chrome.  Browse to some https site.  Use firefox import utility.  Continue browsing https sites.  Shouldn't crash.

Review URL: http://codereview.chromium.org/159165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21251 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/159128


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21250 0039d316-1c4b-4281-b951-d872f2087c98

only supports checking the OS, but we can add more information if
necessary.

BUG=16884

Review URL: http://codereview.chromium.org/159148


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21249 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/159124


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21248 0039d316-1c4b-4281-b951-d872f2087c98

Creating a unique user-agent string for ChromeOS builds, so that metrics can be aggregated separately from standard Chrome on Linux

Review URL: http://codereview.chromium.org/155101
Patch from Chris Masone <cmasone@google.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21247 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11507
TEST=Open options, click change proxy, gnome-network-preferences should launch.  If gnome isn't installed or running, LinuxProxyConfig wiki page should load.

Review URL: http://codereview.chromium.org/155792

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21246 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/17326

Review URL: http://codereview.chromium.org/159159

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21245 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None (no significant changes)

Review URL: http://codereview.chromium.org/159073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21244 0039d316-1c4b-4281-b951-d872f2087c98

Re-trying the previous CL. The last change got reverted because of valgrind
failure.

TBR=scherkus

Original CL: http://codereview.chromium.org/155471

Review URL: http://codereview.chromium.org/159167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21242 0039d316-1c4b-4281-b951-d872f2087c98

name/url editing works.  Get to the edotir from a context menu (Edit,
Add Page).  Also Implement Open All Bookmarks menu item.

BUG=http://crbug.com/8381, http://crbug.com/17006 

TEST=Add some bookmarks.  
Right-click on a bookmark and pick Edit.
Test editing the name and URL.  Make sure you can't add a bogus URL.
Right-click on a bookmark or the bar and Add Page.
Fill in name and URL fields to add a new bookmark.
Right-click Open All Bookmarks and make sure it hoses your machine.

Review URL: http://codereview.chromium.org/155874

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21241 0039d316-1c4b-4281-b951-d872f2087c98

string from the template was used with JST instead of the i18n template
and therefore it did not get recursively processed.

Also make sure we can support recursive handling of setting innerHTML
with the i18n template engine.

BUG=17377

TEST=Navigate to http://ponderer.org/tests/redirect-loop.py The error
page should show: The webpage at http://ponderer.org/tests/redirect-loop.py 
has ...

Review URL: http://codereview.chromium.org/155884

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=9591

TEST=Go to the history page and make sure that "Delete history for this day"
still works and that it does not allow opening the "link" in a new window.

Review URL: http://codereview.chromium.org/155892

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21239 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/159175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21238 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/155828

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21237 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/155896

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21236 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/17126
TEST=net_unittests

Review URL: http://codereview.chromium.org/159034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21234 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes two related problems:

1) Holding down back/forward now stay pressed while the menu is shown.
2) Buttons on the "toolbar" now emulate GTK's toolbar behaviour of only showing
   the border on hover.

http://crbug.com/17308
http://crbug.com/17340

Review URL: http://codereview.chromium.org/159154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21233 0039d316-1c4b-4281-b951-d872f2087c98

Sometimes it's possible for a DOMUI to request images that don't exist (theme provider could specify null, or no custom image is provided). Move DCHECK protection into real code.

BUG=17257
TEST=Run purify as described in bug.

Review URL: http://codereview.chromium.org/159146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21232 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Click arrow part of download item. A context menu should appear.

Review URL: http://codereview.chromium.org/159174

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21231 0039d316-1c4b-4281-b951-d872f2087c98

* The tab strip handles the lifetime of the tab widget, so don't try to increase the ref count in order to destroy the widget later.
* Use DeleteSoon when deleting the dragged tab in order to give gtk a chance to clean up its ref counts added during the drag operation.

BUG=12863
TEST=Extensive tab dragging.  No crashes and the Linux UI valgrind bot should stay green.
Review URL: http://codereview.chromium.org/159166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21230 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=this

Review URL: http://codereview.chromium.org/155842

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21229 0039d316-1c4b-4281-b951-d872f2087c98

gtk: Make GtkThemeProvider own the gtk label widget.  The widget is not added to a container, so we don't have the convenience of having it destroyed by the container.

BUG=none
TEST=Watch the Linux UI valgrind bot get a little greener.
Review URL: http://codereview.chromium.org/159157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21228 0039d316-1c4b-4281-b951-d872f2087c98

It fixes at least two real bugs, one in the tar generator, and one
in stream_bank.h.

Review URL: http://codereview.chromium.org/159168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21227 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155886

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21225 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/159164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21224 0039d316-1c4b-4281-b951-d872f2087c98

so that we get consistent results.  Also bumped up the pdiff threshold for 2d sample
on the mac to its previous number to get the test to pass until we fix it.
Review URL: http://codereview.chromium.org/155885

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21223 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21221 0039d316-1c4b-4281-b951-d872f2087c98

New Linux baselines for dotted/dashed CSS borders, changed by http://bugs.webkit.org/show_bug.cgi?id=27388 .

BUG=http://crbug.com/474
TEST=After sheriff rolls DEPS, Linux buildbots should be greener.

Review URL: http://codereview.chromium.org/155877

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21220 0039d316-1c4b-4281-b951-d872f2087c98

https://bugs.webkit.org/show_bug.cgi?id=27388

BUG=http://crbug.com/474
TEST=Windows webkit bots should be greener after sheriff rolls DEPS.

Review URL: http://codereview.chromium.org/155880

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21219 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21217 0039d316-1c4b-4281-b951-d872f2087c98

Also included in this revert: r21165, r21180, and a couple valgrind suppression edits

TBR=huanr

Review URL: http://codereview.chromium.org/155876

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21216 0039d316-1c4b-4281-b951-d872f2087c98