- Jan 14, 2011
-
-
hbono@chromium.org authored
This change just disables MultiProcessNotificationTests added by r71418 <http://crrev.com/71418> because they always crash on the "Chromium Mac (valgrind)" bot. (We also disable other MultiProcessNotificationTests?) TBR=dmaclach,thestig,timurrrr BUG=69641 TEST=make the "Chromium Mac (valgrind)" bot green. Review URL: http://codereview.chromium.org/6321004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71423 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
interface to the automation provider. The testing automation provider was incorrectly assuming that the tab handle would be a parameter in the TabLoaded message. This changed with jam's change to clean up the automation messages used by chrome frame. The other bug was with the AutomationMsg_Hello message which was passing an incorrect protocol version to chrome frame. BUG=none TEST=ChromeFrame net tests should run. TBR=amit Review URL: http://codereview.chromium.org/6324002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71422 0039d316-1c4b-4281-b951-d872f2087c98
-
gfeher@chromium.org authored
The new concept is the following: policy_templates.json contains all the data necessary to generate templates: policy names, English captions, descriptions, etc. This gets translated the following GRIT gatherer: policy_json.py. The text of the translated JSON file is then picked up, parsed, and passed to the writers by template_formatter.py. BUG=64898 TEST=PolicyJsonUnittest.* Review URL: http://codereview.chromium.org/6134006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71421 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TBR=creis BUG=69637 TEST=browser_tests Review URL: http://codereview.chromium.org/6290003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71420 0039d316-1c4b-4281-b951-d872f2087c98
-
neb@chromium.org authored
David Sehr helped me get the NaCl side working so I'll try to land this again. Previous CL at http://codereview.chromium.org/5837001 BUG=69474 TEST=compiles Review URL: http://codereview.chromium.org/6231003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71419 0039d316-1c4b-4281-b951-d872f2087c98
-
dmaclach@chromium.org authored
This is a platform abstraction for a notification that can be sent between processes. Currently only implemented on Mac. Windows and Linux will be done in a future CL. BUG=NONE TEST=BUILD Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70629 Review URL: http://codereview.chromium.org/5970015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71418 0039d316-1c4b-4281-b951-d872f2087c98
-
hayato@chromium.org authored
BUG=none TEST=none TBR=jschuh Review URL: http://codereview.chromium.org/6306002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71417 0039d316-1c4b-4281-b951-d872f2087c98
-
morrita@chromium.org authored
BUG=69095 TEST=manual Review URL: http://codereview.chromium.org/6203005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71416 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6106004 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/6313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71415 0039d316-1c4b-4281-b951-d872f2087c98
-
kerz@chromium.org authored
Review URL: http://codereview.chromium.org/6301004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71411 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
BUG=67218 TEST=Remoting status is shown on the advanced options page. Review URL: http://codereview.chromium.org/6214003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71410 0039d316-1c4b-4281-b951-d872f2087c98
-
lipalani@chromium.org authored
When a local profile is created we create the corresponding sync node and we need to associate the sync node with profile. We forgot to make the call and that is fixed in this cl. BUG=68912, 69173 TEST= sync_integration_tests Review URL: http://codereview.chromium.org/6323001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71409 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
This option extends url_fetch_test to support waiting for a JavaScript expression to evaluate to true. This is used in the Chrome OS desktopui_GmailLatency test. The browser goes to the test URL and then runs the test to completion. BUG=chromium-os:10869 TEST=test on my workstation on Ubuntu, x86-mario, qemu using a web page which sets a JS value after a period. Original Review URL: http://codereview.chromium.org/6249003/ Signed-off-by:
Simon Glass <sjg@chromium.org> Reviewed-by:
Anton Sargent <asargent@chromium.org> Reviewed-by:
William Chan <willchan@chromium.org> Reviewed-by:
Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/6288003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71408 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
* Test that autofill can be initiated by pressing the down arrow in a fillable field. * Test that autofill works after reloading the page. BUG=69219 TEST=interactive_ui_test --gtest_filter=AutoFillTest.* Review URL: http://codereview.chromium.org/6316001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71406 0039d316-1c4b-4281-b951-d872f2087c98
-
tkent@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6251007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71405 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
IE will create empty properly rendered toolbar instead of white box. Then chrome frame will be placed above. BUG=none TEST=none Review URL: http://codereview.chromium.org/6245001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71404 0039d316-1c4b-4281-b951-d872f2087c98
-
rsimha@chromium.org authored
The sync stress tests (that use 10 sync clients) occasionally time out on the sync builders. The cause is not fully apparent at this time, and it doesn't make sense to arbitrarily increase the test timeout. Disabling tests until a long term fix is found. TBR=tim@chromium.org BUG=69604 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6265003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71403 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
[Not applying the "obvious" fix, since it might lead to callbacks being called incorrectly.] Add some tests (for aborting calls). BUG=none TEST=ppapi_tests Review URL: http://codereview.chromium.org/6220006 TBR=viettrungluu@chromium.org,jam@chromium.org,brettw@chromium.org Review URL: http://codereview.chromium.org/6254003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71400 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/5967003/dtu@chromium.org authored
UITestBase now creates its ProxyLauncher instance in SetUp() rather than its constructor. LaunchState no longer contains references. BUG=none TEST=none Review URL: http://codereview.chromium.org/6111011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71398 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
(moved *.cc using 'svn mv' to preserve history) (copied *.h using 'svn cp' to preserve history and stub out originals) Stubbed out original headers in chrome/browser/gtk/ Update header guards & copyright dates in chrome/browser/ui/gtk/ Update .gypi files Remove chrome/chrome_browser.gypi:4228 reference to nonexistant: ['include', '^browser/gtk/pk11_password_dialog.h'], Remove stray header guard in: chrome/browser/ui/gtk/bookmark_bar_instructions_gtk.cc Add #pragma once to the following files: chrome/browser/ui/gtk/instant_confirm_dialog_gtk.h chrome/browser/ui/gtk/infobar_arrow_model.h Ran the following to appease presubmit: 'svn pset svn:eol-style LF \ chrome/browser/ui/gtk/info_bubble_accelerators_gtk.cc \ chrome/browser/ui/gtk/gtk_custom_menu.cc \ chrome/browser/ui/gtk/info_bubble_accelerators_gtk.h \ chrome/browser/ui/gtk/gtk_custom_menu.h \ chrome/browser/ui/gtk/options/managed_prefs_banner_gtk.h \ chrome/browser/ui/gtk/chrome_gtk_frame.h \ chrome/browser/ui/gtk/chrome_gtk_frame.cc \ chrome/browser/ui/gtk/gtk_custom_menu_item.h \ chrome/browser/gtk/info_bubble_accelerators_gtk.h \ chrome/browser/gtk/gtk_custom_menu.h \ chrome/browser/gtk/options/managed_prefs_banner_gtk.h \ chrome/browser/gtk/chrome_gtk_frame.h \ chrome/browser/gtk/gtk_custom_menu_item.h' BUG=69289 TEST=Compile&Trybots Review URL: http://codereview.chromium.org/6251001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71397 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
BUG=62103 TEST=none TBR=tim Review URL: http://codereview.chromium.org/6341001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71396 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
TBR=gspencer@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71394 0039d316-1c4b-4281-b951-d872f2087c98
-
rsimha@chromium.org authored
Revision 71253 introduced a fake URLFetcher factory to the sync tests. The clean up step of reverting to the default URLFetcher was added to LiveSyncTest::TearDown(), which is run after browser shut down. The correct place to add the clean up step is the method LiveSyncTest::TearDownInProcessBrowserTestFixture(), which is run prior to browser shut down. This patch merely moves the clean up step to the right spot. TBR=akalin@chromium.org BUG=69184, 56729, 53931 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6251004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71392 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
agent before invoking SetSite on the ChromeFrame BHO to ensure that the protocol sink patch is not disabled. BUG=none TEST=Covered by existing ChromeFrame InstallFlowTest. Review URL: http://codereview.chromium.org/6252004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71391 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jan 13, 2011
-
-
apatrick@chromium.org authored
This fixes the case where a NativeViewEGLContext and a SecondaryEGL context are backed by the same EGL surface and the native one, which previously owned the surface, is destroyed first. TEST=try BUG=none Review URL: http://codereview.chromium.org/6296004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71390 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
This will pull in a fix for the bugs below. TEST=try BUG=69470,69573 Review URL: http://codereview.chromium.org/6248005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71389 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
one you reviewed in that I changed a DCHECK in ProcessPendingTabs to an if. See the comments there for details (this was triggering a failure on chromeos). Description from last attempt: With the current code, during closing a window with unload handlers if a tab is disconnected then we delay cleanup by way of PostTask with the tab being disconnected. During the time between when the disconnect happens and the task is run the unloader handler sets still maintain a reference to the tab. If ProcessPendingTabs is invoked during this window and the tab is deleted, then we can crash. I'm fixing it by making disconnect remove from the sets immediately, but delay the call to ProcessPendingTabs. I'm also doing a similar thing in TabDetachedAt. BUG=15620 TEST=none Review URL: http://codereview.chromium.org/6321001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71388 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
TBR=tim BUG=62103 TEST=none Review URL: http://codereview.chromium.org/6266004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71387 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=68782 TEST=manual Review URL: http://codereview.chromium.org/6334001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71385 0039d316-1c4b-4281-b951-d872f2087c98
-
panayiotis@google.com authored
Add a unique ID for each URL in the malware details protocol buffer. This allows us to save some space in the protocol buffer by not repeating the urls of parents and children. Also, change some string fields to bytes to avoid the implicit utf-8 conversion when not applicable. BUG=60831 TEST=relevant unit_tests, browser_tests Review URL: http://codereview.chromium.org/6208003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71384 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
This change fixes an issue where the password completion, when the tab key is used to cycle focus, was causing focus to get lost. BUG=67888 TEST=PasswordAutocompleteManagerTest.*, and manual tests according to bug. Review URL: http://codereview.chromium.org/6280003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71383 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
This patch changes the security model for "chrome" URLs to make implementing some features in DOMUI easier. Instead of registering "chrome" as a NoAccess and a Local scheme, we register it as a DisplayIsolated scheme. That should have the effects outlined in this email: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/863700bf99b3f3ed See also https://bugs.webkit.org/show_bug.cgi?id=50182 which introduces the necessary API into WebKit. BUG=69140 Review URL: http://codereview.chromium.org/5268006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71382 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
BUG=62103 TEST=none Review URL: http://codereview.chromium.org/6309002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71381 0039d316-1c4b-4281-b951-d872f2087c98
-
lzheng@chromium.org authored
BUG=60822 TEST=base_file_unittest.cc Review URL: http://codereview.chromium.org/6023006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71379 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
These are new hosts, but Brocade should be issuing a fix soon (hopefully). Therefore I'm ok adding them to the blacklist. BUG=69379 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71378 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6106004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71377 0039d316-1c4b-4281-b951-d872f2087c98
-
jschuh@chromium.org authored
Review URL: http://codereview.chromium.org/6240003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71374 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
the chrome frame BHO dynamically and verifies whether a subsequent navigation attempt to a chrome frame page works correctly. This started failing since the change to set the user agent in the registry. We need to refresh the IE UA by invoking the UrlMkSetSessionOption API to ensure that the subsequent switching works. BUG=none TEST=Covered by existing ChromeFrame InstallFlowTest. Review URL: http://codereview.chromium.org/6251005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71373 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
Google home page instant works correctly. BUG=none TEST=none Review URL: http://codereview.chromium.org/6331001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71372 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
menu code. It seems like we end up getting mouse events from a widget that is no longer visible. Additionally it seems possible that the selection is cleared before we expect it. Hopefully both of these CHECKs will help figure out what is going on. BUG=62872 TEST=none Review URL: http://codereview.chromium.org/6288002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71371 0039d316-1c4b-4281-b951-d872f2087c98
-