Also, always show the apps section. We were only hiding it when
there was zero elements when we were in our transitionary
phase. To make this look less weird when there are actually
zero elements, add the webstore element to the miniview and
closed menus.

BUG=64737
TEST=In a fresh profile, go to chrome://extensions/ -> developer mode,
and click 'update now'. Go to NTP. Should see default apps. Remove
all default apps. Apps section should remain. Collapse apps section
by clicking heading. Should see webstore item in minimized view. Hide
apps section by clicking 'x'. Should see webstore item in closed
section menu on bottom of page.

Review URL: http://codereview.chromium.org/5804005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69180 0039d316-1c4b-4281-b951-d872f2087c98

This was a timing issue: we had a pref change observer that was
triggering refresh of NTP. Inside this refresh, we checked the
promo status. But setting up the pref tree of an extension
during installation was also triggering this listener.

BUG=64736
TEST=See bug

Review URL: http://codereview.chromium.org/5750005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69164 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52451
TEST=Manually create app shortcuts for urls and apps.

Review URL: http://codereview.chromium.org/5273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67664 0039d316-1c4b-4281-b951-d872f2087c98

BUG=59697
TEST=BrowserTest.OpenAppWindowLikeNtp,SessionRestoreUITest.RestoreAfterClosing*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66646

Review URL: http://codereview.chromium.org/5019005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66954 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63415
TEST=Install and App.
  Go to the NTP
  Right clicking on the app in expanded/small/minimized mode
  This should bring up a context menu in all cases.

Review URL: http://codereview.chromium.org/5234005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66855 0039d316-1c4b-4281-b951-d872f2087c98

BUG=59697
TEST=BrowserTest.OpenAppWindowLikeNtp,SessionRestoreUITest.RestoreAfterClosing*

Review URL: http://codereview.chromium.org/5019005

TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/5168004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66665 0039d316-1c4b-4281-b951-d872f2087c98

BUG=59697
TEST=BrowserTest.OpenAppWindowLikeNtp,SessionRestoreUITest.RestoreAfterClosing*

Review URL: http://codereview.chromium.org/5019005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66646 0039d316-1c4b-4281-b951-d872f2087c98

Creates an enumeration histogram called Extensions.AppsPromo with the following buckets:
0: launched an application from the promo
1: launched the web store from the promo
2: manually closed the promo (and uninstalled the applications)
3: promo expired

BUG=61017
TEST=

Review URL: http://codereview.chromium.org/4708002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66006 0039d316-1c4b-4281-b951-d872f2087c98

installed, even if the installation is through default
installation.

BUG=61973
TEST=Have an app installed, then close apps section, then install a new app. Apps section should re-open.

Review URL: http://codereview.chromium.org/4506002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65213 0039d316-1c4b-4281-b951-d872f2087c98

Adds the --enable-app-launcher command line switch, which displays the app launcher on the new tab page when present. Now the app launcher is shown on NTP if there are 1 or more apps installed, or if this switch is present.

BUG=59532
TEST=You should see the Apps section on the new tab page when chrome is run with --enable-app-launcher.

Review URL: http://codereview.chromium.org/3808009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63103 0039d316-1c4b-4281-b951-d872f2087c98

Also, minor adjustment to spacing at bottom of
scrollable areas.

BUG=59235
TEST=Install enough apps so that the apps section scrolls,
and then install one more. Apps section should scroll to
bottom so that you can see the animation happen.

Review URL: http://codereview.chromium.org/3771007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62977 0039d316-1c4b-4281-b951-d872f2087c98

When there is less than one complete row of apps, position the
web store icon naturally in the grid, to the right of the other
apps.

Once there is at least one complete row, position the web store
icon at the top of the right-most column.

BUG=58857
TEST=Install a few apps. Web store icon should be in top row
directly to the right of the other apps. Install more apps.
Once you have more than one row, web store icon should stay
in top right corner by itself. No other apps should go below
it.

Review URL: http://codereview.chromium.org/3747007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62962 0039d316-1c4b-4281-b951-d872f2087c98

Add the concept of app_launch_index, stored with the extension that determines an install order which is used to order the apps on the new tab page. 

BUG=57090
TEST=None

Review URL: http://codereview.chromium.org/3611014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62112 0039d316-1c4b-4281-b951-d872f2087c98

the component extension system, simply install them as
normal apps the first time Chrome runs. Remove the old
style  default apps.

This also removes support for --disable-apps, which doesn't
seem necessary since we already have --disable-extensions.

BUG=53972
TEST=Uninstall any installed apps. Remove the
"default_apps_installed" and "app_promo_counter" keys from
Preferences if they are present.

Start Chrome with the --enable-default-apps flag, navigate
to chrome://extensions/, and click "update now" in the
developer tools. This is to make the  updater grab the
apps from the store quicker, so that you don't have to wait
while testing. Normally Chrome would do this by itself
after 5-40 mins.

Go to NTP. You should see gmail, calendar, and docs default
apps show up along with the promo (the text that says "New!
A world of ...").

Refresh the NTP 10 times. The promo should go away on the
10th time.

There are other details. To test each of these, remove all
installed apps and remove the keys from the preferences to
reset the state.

* If you close Chrome before getting the default apps. They
should still show up the next time Chrome is started (after
clicking 'Update now')

* Clicking "hide this message" should hide the promo and it
shouldn't come back on refresh.

* Installing or uninstalling any app should hide the promo,
and it shouldn't come back.

* If the keys from the preferences are removed, but apps
are left installed, the default apps should not be
installed  when clicking 'update now'.

* The default apps should only be installed in locale
en-US.

Review URL: http://codereview.chromium.org/3522015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62084 0039d316-1c4b-4281-b951-d872f2087c98

show it at the correct time.

BUG=53972
TEST=chrome --force-apps-promo-visible, open NTP. Should see promo.

Review URL: http://codereview.chromium.org/3538014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61797 0039d316-1c4b-4281-b951-d872f2087c98

BUG=55148
TEST=Minimize apps section. Install an app. Apps section should no longer be minimized.

Review URL: http://codereview.chromium.org/3555010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61388 0039d316-1c4b-4281-b951-d872f2087c98

This implements http://folder/glen/chrome/spec/101_ntp/8_wish&sidebar mocks 2, 5, 6

It's a bit lame to use a bit in the "sections" bitmask to serialize the "should show?" information, but the damage here was done when someone decided to that "THUBMS bit missing" should mean "show a list instead" (instead of adding another bit for that).

BUG=55148
TEST=Hover "Most Visited" bar. Close button should appear. Clicking it should hide "Most Visited" area and add a button at the window edge. That button should have a menu that makes it possible to make the "Most Visited" area visible again. Also do this while multiple NTPs are open; the changes made in the front NTP should be synced to the background NTPs.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61095

Review URL: http://codereview.chromium.org/3455007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61259 0039d316-1c4b-4281-b951-d872f2087c98

this and I don't feel comfortable leaving it on trunk while
they are ironed out.

The terminology in the code is a bit schizophrenic at the
moment, so for clarity:

open = big icons showing
closed = small icons showing
hidden = no icons showing (button in bottom of tab)

1. If the apps section is hidden and an app is installed, the
apps section comes back weirdly. The content is visible, but
the header is not and the menu along the bottom of the tab
is still there.

2. Sections' open state not persisted. If you click on a
header to make a section open, then refresh, that section is
closed again.

3. If you open the most visited section, then refresh, the
most visited section will look closed. But if you hover in
the empty area in the bottom of the tab, you will get
cursor changes and status bubbles. This is probably related
to 2, above.

These aren't that hard to fix probably, but there are a few
other high priority minor fixes I need to get in for m7,
and I'm afraid of this change conflicting with them for
merges. So I'm pulling this out until one of us has time to
get back to it.

TBR=thakis@chromium.org
BUG=55148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61130 0039d316-1c4b-4281-b951-d872f2087c98

closed in the case where no apps are installed.

BUG=56867
TEST=Have no apps installed. Open NTP. Hide MV section. Open
another NTP. MV section should be hidden.

Review URL: http://codereview.chromium.org/3609002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61116 0039d316-1c4b-4281-b951-d872f2087c98

This implements http://folder/glen/chrome/spec/101_ntp/8_wish&sidebar mocks 2, 5, 6

It's a bit lame to use a bit in the "sections" bitmask to serialize the "should show?" information, but the damage here was done when someone decided to that "THUBMS bit missing" should mean "show a list instead" (instead of adding another bit for that).

BUG=55148
TEST=Hover "Most Visited" bar. Close button should appear. Clicking it should hide "Most Visited" area and add a button at the window edge. That button should have a menu that makes it possible to make the "Most Visited" area visible again. Also do this while multiple NTPs are open; the changes made in the front NTP should be synced to the background NTPs.

Review URL: http://codereview.chromium.org/3455007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61095 0039d316-1c4b-4281-b951-d872f2087c98

o Updated some comments that were using the outdated NOTIFY_PREF_CHANGED notification.
o Make LAUNCH_PINNED the default type returned by ExtensionPrefs if it does not already exist.
o Some minor refactoring within the code to reduce duplication.

BUG=54731
TEST=NONE

patch from issue 3419010

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60997

Reverted: http://crrev.com/61000

Review URL: http://codereview.chromium.org/3453029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61021 0039d316-1c4b-4281-b951-d872f2087c98

Revert 60997 - o Add user customizable launch type for apps by adding options in each apps context menu.
o Updated some comments that were using the outdated NOTIFY_PREF_CHANGED notification.
o Make LAUNCH_PINNED the default type returned by ExtensionPrefs if it does not already exist.
o Some minor refactoring within the code to reduce duplication.

BUG=54731
TEST=NONE

patch from issue 3419010

Review URL: http://codereview.chromium.org/3453029

TBR=andybons@chromium.org
Review URL: http://codereview.chromium.org/3517004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61000 0039d316-1c4b-4281-b951-d872f2087c98

o Updated some comments that were using the outdated NOTIFY_PREF_CHANGED notification.
o Make LAUNCH_PINNED the default type returned by ExtensionPrefs if it does not already exist.
o Some minor refactoring within the code to reduce duplication.

BUG=54731
TEST=NONE

patch from issue 3419010

Review URL: http://codereview.chromium.org/3453029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60997 0039d316-1c4b-4281-b951-d872f2087c98

same page was uninstalled.

BUG=56454
TEST=Install one app, then another. Uninstall the first one.
Second one's install animation should not replay.

Review URL: http://codereview.chromium.org/3396021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60391 0039d316-1c4b-4281-b951-d872f2087c98

and apps data. This improves performance and avoids
flickeryness.

BUG=56278
TEST=Install some apps and refresh the ntp over and over.
Should not see flickering as mv section, then apps load.

Review URL: http://codereview.chromium.org/3474006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60306 0039d316-1c4b-4281-b951-d872f2087c98

sections if both sections were shown under the old version
of the ntp.

Also clean up some old cruft.

BUG=55610
TEST=Upgrade Chrome from an older version to a version with
this change with at least one app installed. Should see only
apps section. Do it with no apps installed, should see only
MV section.

Review URL: http://codereview.chromium.org/3393013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60216 0039d316-1c4b-4281-b951-d872f2087c98

The uninstall dialog used to say:

[===============================x]
|Confirm Uninstallation          |
|--------------------------------|
|<b>Uninstall Foo Extension?</b> |
|                                |
|Are you sure you want to        |
|uninstall this extension?       |
|                                |
|================================|

We don't have the bottom string with the word 'app', and I
realized it is somewhat extraneous anyway. So just removed it
in all cases and de-bolded the text above. Looks much better.

Also, fixed a bug where the icon we display in the GTK
dialogs is too big by doing image resizing in
ExtensionInstallUI.

BUG=54874
TEST=Uninstall app and extension. Both should have a prompt,
and UI layout should be the same.

Review URL: http://codereview.chromium.org/3332016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59157 0039d316-1c4b-4281-b951-d872f2087c98

o Only do the bounce animation once when installing an app. Collapsing and expanding the apps section would cause the new app icon to bounce again.
o Expand the Apps section if it is collapsed and a new app isn't installed.

BUG=53974,54421
TEST=manual

Review URL: http://codereview.chromium.org/3371010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59014 0039d316-1c4b-4281-b951-d872f2087c98

This uses the cr Menu system and replaces the old options menu with a cr Menu.

BUG=52446
TEST=Start chrome with enable-apps. Install some apps.
Right clicking on an app should show a context menu.
Clicking the wrench should show the same menu.


Review URL: http://codereview.chromium.org/3315005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58648 0039d316-1c4b-4281-b951-d872f2087c98

BUG=53978
TEST=Install an app. Expand and collapse sections. Things should swish.

Review URL: http://codereview.chromium.org/3346006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58556 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/3342009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58533 0039d316-1c4b-4281-b951-d872f2087c98

Instead of trying to arrange things so that there is something covering all the parts of the scrollable area we don't want to see, use -webkit-image-mask to only show the parts we do want to see.

This change also fixes overflow of miniview items. Under some circumstances, the old JS approach wasn't working. Used a CSS one instead.

TEST=Set up most visisted so that it has items. Start it in
expanded mode. Minimize it. There should be no clipped last
item.

Review URL: http://codereview.chromium.org/3363001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58451 0039d316-1c4b-4281-b951-d872f2087c98

* When there are no apps, don't show the apps section.
* Expand the MV section by default, like it was in M6.
* Fix bug where recently closed is incorrectly toggleable.
* Stop showing miniview items for MV section when there is no more room.
* Don't show filler MV items in miniview.
* MV section is 5px too high because we were only apply extra padding
  to the first section, even if that section was disabled.

TEST=Visual inspection.

Review URL: http://codereview.chromium.org/3292003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58139 0039d316-1c4b-4281-b951-d872f2087c98

BUG=53248

Review URL: http://codereview.chromium.org/3250002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57966 0039d316-1c4b-4281-b951-d872f2087c98

Add the collapsed 'miniview' to the apps and most visisted sections. Also, fix the bug where the wrench disappears on hover.

BUG=53248,52199

Review URL: http://codereview.chromium.org/3236001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57799 0039d316-1c4b-4281-b951-d872f2087c98

TBR=eroman@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57492 0039d316-1c4b-4281-b951-d872f2087c98

TBR=eroman@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57478 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't do any behavior changes -- it just implements
the styling. So we still have multi expand, and the recently
closed section is still toggleable.

I also didn't make the changes to the placement or text of
the web store icon. I will make those separately.

Screen caps:
http://aaronboodman.com/z_dropbox/cr3156049/

BUG=53248

Review URL: http://codereview.chromium.org/3156049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57473 0039d316-1c4b-4281-b951-d872f2087c98

1. If no apps are installed we add an item for the store to the most visited section.
2. No longer hide the most visited by default.
3. This removes the default apps on non ChromeOS

BUG=46028, 47700
TEST=With a clean profile without any apps installed you should see the store thumbnail unless you blacklist it or pin 8 ohter pages.

Review URL: http://codereview.chromium.org/3001003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52998 0039d316-1c4b-4281-b951-d872f2087c98

BUG=44915
TEST=Start chrome with --enable-apps (and optionally --enable-accelerated-compositing). Install some apps. Now hover over the app icon and click the wrench icon.

Review URL: http://codereview.chromium.org/2832014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50368 0039d316-1c4b-4281-b951-d872f2087c98