Commit 1456efe7 authored by Sebastian Fricke's avatar Sebastian Fricke Committed by Kieran Bingham
Browse files

ipa: rkisp1: Do not set controls during configure



Do not send events back to the pipeline handler, while the IPA thread
has not been started.

If information needs to be returned from configure it should be returned
directly.

Move the initial call to setControls() out of configure() and into the
start() method which is called after the IPA running_ state is updated.
Reviewed-by: default avatarKieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarPaul Elder <paul.elder@ideasonboard.com>
Signed-off-by: default avatarSebastian Fricke <sebastian.fricke@posteo.net>
Signed-off-by: default avatarKieran Bingham <kieran.bingham@ideasonboard.com>
parent 92cad298
......@@ -32,7 +32,7 @@ class IPARkISP1 : public ipa::rkisp1::IPARkISP1Interface
{
public:
int init(unsigned int hwRevision) override;
int start() override { return 0; }
int start() override;
void stop() override {}
int configure(const CameraSensorInfo &info,
......@@ -80,6 +80,13 @@ int IPARkISP1::init(unsigned int hwRevision)
return 0;
}
int IPARkISP1::start()
{
setControls(0);
return 0;
}
/**
* \todo The RkISP1 pipeline currently provides an empty CameraSensorInfo
* if the connected sensor does not provide enough information to properly
......@@ -121,7 +128,6 @@ int IPARkISP1::configure([[maybe_unused]] const CameraSensorInfo &info,
<< "Exposure: " << minExposure_ << "-" << maxExposure_
<< " Gain: " << minGain_ << "-" << maxGain_;
setControls(0);
return 0;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment